linux-kernel - Re: [PATCH] hpfs: add checks for ea addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250723024548.GM2580412@ZenIV>
Date: Wed, 23 Jul 2025 03:45:48 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Antoni Pokusinski <apokusinski01@...il.com>
Cc: linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
	syzbot+fa88eb476e42878f2844@...kaller.appspotmail.com
Subject: Re: [PATCH] hpfs: add checks for ea addresses

On Sun, Jul 20, 2025 at 02:34:27PM +0200, Antoni Pokusinski wrote:

>  	ea_end = fnode_end_ea(fnode);
> -	for (ea = fnode_ea(fnode); ea < ea_end; ea = next_ea(ea))
> +	for (ea = fnode_ea(fnode); ea < ea_end && ea_valid_addr(fnode, ea); ea = next_ea(ea))

That looks really fishy.  If nothing else, your ea_valid_addr() is a range check;
are there any situations where we would want to allow fnode_ea() and fnode_end_ea()
be out of that range?