linux-kernel - Re: [PATCH v2] drm/panel-edp: Add 50ms disable delay for four panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XB0s_-qxm0p+vV96iJUxAwhcsvzFkOh1nhso2WkDoC2g@mail.gmail.com>
Date: Wed, 23 Jul 2025 09:03:31 -0700
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, jessica.zhang@....qualcomm.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/panel-edp: Add 50ms disable delay for four panels

Hi,

On Wed, Jul 23, 2025 at 12:25 AM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> Add 50ms disable delay for NV116WHM-N49, NV122WUM-N41, and MNC207QS1-1
> to satisfy T9+T10 timing. Add 50ms disable delay for MNE007JA1-2
> as well, since MNE007JA1-2 copies the timing of MNC207QS1-1.
>
> Specifically, it should be noted that the MNE007JA1-2 panel was added
> by someone who did not have the panel documentation, so they simply
> copied the timing from the MNC207QS1-1 panel. Adding an extra 50 ms
> of delay should be safe.
>
> Fixes: 0547692ac146 ("drm/panel-edp: Add several generic edp panels")
> Fixes: 50625eab3972 ("drm/edp-panel: Add panel used by T14s Gen6 Snapdragon")
> Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> ---
> v2:
>   - Deleted "delay_200_500_e50_d50_p2e200" structure and renamed/replaced "delay_200_500_e50_p2e200"
>   - Link to v1: https://lore.kernel.org/all/20250722024512.983313-1-yelangyan@huaqin.corp-partner.google.com/
> ---
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

Thanks! This looks good to me now:

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I looked at pushing this to drm-misc-fixes but it didn't apply cleanly
due to context. Given that the original patch is 1.5 years old and the
only reported problems are that timings were violated (probably tested
on a scope), I'm going to say it's not worth it to make someone deal
with a merge conflict so I'm just applying to drm-misc-next.

Pushed to drm-misc-next:

[1/1] drm/panel-edp: Add 50ms disable delay for four panels
      commit: 1511d3c4d2bb30f784924a877f3cef518bb73077