linux-kernel - Re: [PATCH v3 5/8] perf annotate: Add --code-with-type support for TUI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIEJaKDNBor71jIn@x1>
Date: Wed, 23 Jul 2025 13:10:16 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Namhyung Kim <namhyung@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v3 5/8] perf annotate: Add --code-with-type support for
 TUI

On Wed, Jul 16, 2025 at 01:42:13PM -0700, Ian Rogers wrote:
> affects sorting. In general I think we should move away from file
> paths, inodes and the like as the build IDs will avoid races, work
> across systems, etc. I think in this case we could add:

<SNIP>

> but in the future we can find the debuginfo off of the build ID and paths, etc.

Yeah, agreed, we better move to make build-id the primary means of
getting what is needed, when that isn't possible, fall back to
filenames.

Then we should check if the hostname in the perf.data header is the same
as the machine running to warn the user about that, other options are to
check the time the perf.data file was created to warn that its likely
updates took place, so take the results with a grain of salt, etc.

If the architecture or distro is different, things we can also see from
the perf.data files, outright refuse to use filenames :-)

- Arnaldo