linux-kernel - Re: [PATCH] platform/chrome: cros_ec_typec: Check ec platform device pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIBV_mKsV4Yn5XMY@google.com>
Date: Wed, 23 Jul 2025 03:24:46 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Tomasz Michalec <tmichalec@...gle.com>
Cc: Benson Leung <bleung@...omium.org>,
	Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
	Jameson Thies <jthies@...gle.com>,
	Andrei Kuchynski <akuchynski@...omium.org>,
	Guenter Roeck <groeck@...omium.org>,
	Konrad Adamczyk <konrada@...gle.com>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	chromeos-krk-upstreaming@...gle.com
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Check ec platform device
 pointer

On Tue, Jul 22, 2025 at 03:28:26PM +0200, Tomasz Michalec wrote:
> It is possible that parent device for cros_ec_typec device is already
> available, but ec pointer in parent driver data isn't populated yet. It
> may happen when cros_typec_probe is running in parallel with
> cros_ec_register. This leads to NULL pointer dereference when
> cros_typec_probe tries to get driver data from typec->ec->ec->dev.
> 
> Check if typec->ec->ec is set before using it in cros_typec_probe.
>
> [...]

Please use at least for-next branch as the commit base next time.  I have
fixed it this time.

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: cros_ec_typec: Check ec platform device pointer
      commit: 731a4702b668ef28730e7d2414672b7085e757d6

Thanks!