linux-kernel - Re: [PATCH v5] coresight: Replace scnprintf/sprintf with sysfs_emit()/sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507240249.8WCThmh3-lkp@intel.com>
Date: Thu, 24 Jul 2025 02:18:26 +0800
From: kernel test robot <lkp@...el.com>
To: Chelsy Ratnawat <chelsyratnawat2001@...il.com>, suzuki.poulose@....com,
	mike.leach@...aro.org, alexander.shishkin@...ux.intel.com,
	alexandre.torgue@...s.st.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	james.clark@...aro.org, mcoquelin.stm32@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Chelsy Ratnawat <chelsyratnawat2001@...il.com>
Subject: Re: [PATCH v5] coresight: Replace scnprintf/sprintf with
 sysfs_emit()/sysfs_emit_at()

Hi Chelsy,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20250722]
[cannot apply to atorgue-stm32/stm32-next soc/for-next linus/master v6.16-rc7 v6.16-rc6 v6.16-rc5 v6.16-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chelsy-Ratnawat/coresight-Replace-scnprintf-sprintf-with-sysfs_emit-sysfs_emit_at/20250723-024400
base:   next-20250722
patch link:    https://lore.kernel.org/r/20250722184106.3290455-1-chelsyratnawat2001%40gmail.com
patch subject: [PATCH v5] coresight: Replace scnprintf/sprintf with sysfs_emit()/sysfs_emit_at()
config: arm64-randconfig-001-20250723 (https://download.01.org/0day-ci/archive/20250724/202507240249.8WCThmh3-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 853c343b45b3e83cc5eeef5a52fc8cc9d8a09252)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250724/202507240249.8WCThmh3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507240249.8WCThmh3-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:127:20: error: use of undeclared identifier 'bu'
     127 |         return sysfs_emit(bu, "%#lx\n", val);
         |                           ^~
>> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:1336:26: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const char *' [-Wint-conversion]
    1336 |                 size = sysfs_emit(buf, size, "addr_cmp[%i] unused\n", idx);
         |                                        ^~~~
   include/linux/sysfs.h:492:39: note: passing argument to parameter 'fmt' here
     492 | int sysfs_emit(char *buf, const char *fmt, ...);
         |                                       ^
   2 errors generated.


vim +/bu +127 drivers/hwtracing/coresight/coresight-etm4x-sysfs.c

   118	
   119	static ssize_t numvmidc_show(struct device *dev,
   120				     struct device_attribute *attr,
   121				     char *buf)
   122	{
   123		unsigned long val;
   124		struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
   125	
   126		val = drvdata->numvmidc;
 > 127		return sysfs_emit(bu, "%#lx\n", val);
   128	}
   129	static DEVICE_ATTR_RO(numvmidc);
   130	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki