linux-kernel - Re: [PATCH] crypto: ccp: reduce stack usage in ccp_run_aes_gcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de7c13f7-42a7-947d-0973-80ecd814aa42@amd.com>
Date: Wed, 23 Jul 2025 13:23:05 -0500
From: Tom Lendacky <thomas.lendacky@....com>
To: Arnd Bergmann <arnd@...nel.org>, John Allen <john.allen@....com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>
Cc: Arnd Bergmann <arnd@...db.de>, linux-crypto@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: reduce stack usage in ccp_run_aes_gcm_cmd

On 7/14/25 09:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A number of functions in this file have large structures on the stack,
> ccp_run_aes_gcm_cmd() being the worst, in particular when KASAN
> is enabled on gcc:
> 
> drivers/crypto/ccp/ccp-ops.c: In function 'ccp_run_sha_cmd':
> drivers/crypto/ccp/ccp-ops.c:1833:1: error: the frame size of 1136 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> drivers/crypto/ccp/ccp-ops.c: In function 'ccp_run_aes_gcm_cmd':
> drivers/crypto/ccp/ccp-ops.c:914:1: error: the frame size of 1632 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> Avoid the issue by using dynamic memory allocation in the worst one
> of these.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
> I'm not overly happy with this patch myself but couldn't come up
> with anything better either.
> 
> One alternative would be to turn off sanitizers here, but even without
> those, the stack usage is fairly high, so that still feels like
> papering over the problem.
> ---