linux-kernel - Re: [PATCH v3] rust: remove spurious compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9ns1nK9ZdYO4DBwp6JaC6DEVafXjW4OKnsF3mGEVc3X7Q@mail.gmail.com>
Date: Wed, 23 Jul 2025 16:12:44 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Benno Lossin <lossin@...nel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] rust: remove spurious compiler_builtins dependents

On Wed, Jul 23, 2025 at 3:53 PM Benno Lossin <lossin@...nel.org> wrote:
>
> On Wed Jul 23, 2025 at 5:18 PM CEST, Tamir Duberstein wrote:
> > On Mon, Jul 21, 2025 at 8:25 AM Miguel Ojeda
> > <miguel.ojeda.sandonis@...il.com> wrote:
> >>
> >> On Sun, Jul 20, 2025 at 7:20 PM Tamir Duberstein <tamird@...il.com> wrote:
> >> >
> >> > Remove these dependency edges.
> >>
> >> I should have replied in previous versions: this is wrong -- the 3
> >> changes each individually break the build.
> >>
> >> I guess that you are not cleaning everything in your tests before
> >> testing the build.
> >
> > You're absolutely right, this patch is incorrect. I was indeed not
> > blowing away build artifcats.
>
> So is the `compiler_builtins` dependency correct for all crates?

Looks that way to me.