linux-kernel - Re: [PATCH v3] khugepaged: Reduce race probability between migration and khugepaged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA1CXcD2fRc-apfDi2UtQ-cvDwazxOu+bAVnKvVj2rgwdHedsA@mail.gmail.com>
Date: Wed, 23 Jul 2025 15:13:30 -0600
From: Nico Pache <npache@...hat.com>
To: Dev Jain <dev.jain@....com>
Cc: akpm@...ux-foundation.org, david@...hat.com, ziy@...dia.com, 
	baolin.wang@...ux.alibaba.com, lorenzo.stoakes@...cle.com, 
	Liam.Howlett@...cle.com, ryan.roberts@....com, baohua@...nel.org, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	Oscar Salvador <osalvador@...e.de>, Anshuman Khandual <anshuman.khandual@....com>
Subject: Re: [PATCH v3] khugepaged: Reduce race probability between migration
 and khugepaged

On Thu, Jul 3, 2025 at 10:04 PM Dev Jain <dev.jain@....com> wrote:
>
> Suppose a folio is under migration, and khugepaged is also trying to
> collapse it. collapse_pte_mapped_thp() will retrieve the folio from the
> page cache via filemap_lock_folio(), thus taking a reference on the folio
> and sleeping on the folio lock, since the lock is held by the migration
> path. Migration will then fail in
> __folio_migrate_mapping -> folio_ref_freeze. Reduce the probability of
> such a race happening (leading to migration failure) by bailing out
> if we detect a PMD is marked with a migration entry.
>
> This fixes the migration-shared-anon-thp testcase failure on Apple M3.
>
> Note that, this is not a "fix" since it only reduces the chance of
> interference of khugepaged with migration, wherein both the kernel
> functionalities are deemed "best-effort".
>
> Acked-by: David Hildenbrand <david@...hat.com>
> Acked-by: Oscar Salvador <osalvador@...e.de>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>
> Reviewed-by: Zi Yan <ziy@...dia.com>
> Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> Signed-off-by: Dev Jain <dev.jain@....com>

LGTM! This is a nice check to have here :)

Reviewed-by: Nico Pache <npache@...hat.com>
> ---
>
> v2->v3:
>  - Improve comment (David)
>
> v1->v2:
>  - Remove SCAN_PMD_MIGRATION, merge into SCAN_PMD_MAPPED (David, Anshuman)
>  - Add a comment (Lorenzo)
>
> v1:
>  - https://lore.kernel.org/all/20250630044837.4675-1-dev.jain@arm.com/
>
>  mm/khugepaged.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 1aa7ca67c756..a55fb1dcd224 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -941,6 +941,14 @@ static inline int check_pmd_state(pmd_t *pmd)
>
>         if (pmd_none(pmde))
>                 return SCAN_PMD_NONE;
> +
> +       /*
> +        * The folio may be under migration when khugepaged is trying to
> +        * collapse it. Migration success or failure will eventually end
> +        * up with a present PMD mapping a folio again.
> +        */
> +       if (is_pmd_migration_entry(pmde))
> +               return SCAN_PMD_MAPPED;
>         if (!pmd_present(pmde))
>                 return SCAN_PMD_NULL;
>         if (pmd_trans_huge(pmde))
> --
> 2.30.2
>