| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fXCCKn5EREFCrS5JpRf_Y2ueWAd0cXy4fBfLQcP3XmqJA@mail.gmail.com>
Date: Wed, 23 Jul 2025 14:30:47 -0700
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>,
James Clark <james.clark@...aro.org>, Xu Yang <xu.yang_2@....com>,
"Masami Hiramatsu (Google)" <mhiramat@...nel.org>, Collin Funk <collin.funk1@...il.com>,
Howard Chu <howardchu95@...il.com>, Weilin Wang <weilin.wang@...el.com>,
Andi Kleen <ak@...ux.intel.com>, "Dr. David Alan Gilbert" <linux@...blig.org>,
Thomas Richter <tmricht@...ux.ibm.com>, Tiezhu Yang <yangtiezhu@...ngson.cn>,
Gautam Menghani <gautam@...ux.ibm.com>, Thomas Falcon <thomas.falcon@...el.com>,
Chun-Tse Shao <ctshao@...gle.com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v7 00/16] New perf ilist app
On Wed, Jul 23, 2025 at 12:24 PM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> On Wed, Jul 23, 2025 at 04:11:13PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Wed, Jul 23, 2025 at 04:08:55PM -0300, Arnaldo Carvalho de Melo wrote:
> > > On Wed, Jul 23, 2025 at 11:00:18AM -0700, Namhyung Kim wrote:
> > > > > I think there is some follow up for "make install" for scripts like
> > > > > these, but I'm keen for the python API to move forward.
>
> > > > I'll review the series today so that we can get some part of it, at
> > > > least. Basically I think we need a wrapper script like perf-ilist to
> > > > run this easily (maybe with documentation).
>
> > > I just tried, with the series applied:
>
> > > root@...ber:~# perf ilist
> > > perf: 'ilist' is not a perf-command. See 'perf --help'.
>
> > > Did you mean this?
> > > list
> > > root@...ber:~#
>
> > > Now trying to figure out why it is not running.
>
> > So it is not wired up like 'perf archive', trying it directly:
>
> > root@...ber:~# ~acme/git/perf-tools-next/tools/perf/python/ilist.py
> > Traceback (most recent call last):
> > File "/home/acme/git/perf-tools-next/tools/perf/python/ilist.py", line 11, in <module>
> > from textual import on
> > ModuleNotFoundError: No module named 'textual'
> > root@...ber:~#
>
> > I thought there was some discussion about catching this exception and
> > providing guidance, lemme try...
>
> root@...ber:~# sudo dnf install python-textual
> Updating and loading repositories:
> google-chrome 100% | 6.1 KiB/s | 1.3 KiB | 00m00s
> Copr repo for PyCharm owned by phracek 100% | 2.0 KiB/s | 2.1 KiB | 00m01s
> RPM Fusion for Fedora 42 - Nonfree - NVIDIA Driver 100% | 2.6 KiB/s | 2.5 KiB | 00m01s
> RPM Fusion for Fedora 42 - Nonfree - Steam 100% | 5.8 KiB/s | 2.4 KiB | 00m00s
> google-chrome 100% | 7.2 KiB/s | 3.2 KiB | 00m00s
> Copr repo for PyCharm owned by phracek 100% | 15.7 KiB/s | 4.8 KiB | 00m00s
> Repositories loaded.
> Package Arch Version Repository Size
> Installing:
> python3-textual noarch 1.0.0-1.fc42 fedora 6.6 MiB
> Installing dependencies:
> python3-linkify-it-py noarch 2.0.3-4.fc42 fedora 110.4 KiB
> python3-markdown-it-py noarch 3.0.0-8.fc42 fedora 496.3 KiB
> python3-markdown-it-py+linkify noarch 3.0.0-8.fc42 fedora 9.0 KiB
> python3-markdown-it-py+plugins noarch 3.0.0-8.fc42 fedora 9.0 KiB
> python3-mdit-py-plugins noarch 0.4.2-2.fc42 fedora 289.4 KiB
> python3-mdurl noarch 0.1.2-9.fc42 fedora 41.4 KiB
> python3-platformdirs noarch 4.2.2-4.fc42 fedora 162.0 KiB
> python3-pygments noarch 2.18.0-4.fc42 fedora 10.6 MiB
> python3-rich noarch 13.9.4-2.fc42 fedora 2.5 MiB
> python3-uc-micro-py noarch 1.0.3-4.fc42 fedora 13.1 KiB
>
> Transaction Summary:
> Installing: 11 packages
>
> Total size of inbound packages is 5 MiB. Need to download 5 MiB.
> After this operation, 21 MiB extra will be used (install 21 MiB, remove 0 B).
> Is this ok [y/N]: y
> <SNIP>
> [13/13] Installing python3-textual-0:1.0.0-1.fc42.noarch 100% | 10.1 MiB/s | 6.8 MiB | 00m01s
> Complete!
> root@...ber:~# ~acme/git/perf-tools-next/tools/perf/python/ilist.py
> ╭────────────────────────────────────────────────────────────────── Traceback (most recent call last) ──────────────────────────────────────────────────────────────────╮
> │ /home/acme/git/perf-tools-next/tools/perf/python/ilist.py:470 in compose │
> │ │
> │ 467 │ │ │ return tree │
> │ 468 │ │ │
> │ 469 │ │ yield Header(id="header") │
> │ ❱ 470 │ │ yield Horizontal(Vertical(metric_event_tree(), id="events"), │
> │ 471 │ │ │ │ │ │ Vertical(Label("event name", id="event_name"), │
> │ 472 │ │ │ │ │ │ │ │ Static("description", markup=False, id="event_descript │
> │ 473 │ │ │ │ │ │ │ │ )) │
> │ │
> │ ╭───────────────────────────────────────────────── locals ─────────────────────────────────────────────────╮ │
> │ │ self = IListApp(title='Interactive Perf List', classes={'-dark-mode'}, pseudo_classes={'dark', 'focus'}) │ │
> │ ╰──────────────────────────────────────────────────────────────────────────────────────────────────────────╯ │
> │ │
> │ /home/acme/git/perf-tools-next/tools/perf/python/ilist.py:433 in metric_event_tree │
> │ │
> │ 430 │ │ │ """Create tree of PMUs and metricgroups with events or metrics under.""" ╭─────────── locals ────────────╮ │
> │ 431 │ │ │ tree: Tree[TreeValue] = Tree("Root", id="root") │ pmus = TreeNode('PMUs', None) │ │
> │ 432 │ │ │ pmus = tree.root.add("PMUs") │ tree = Tree(id='root') │ │
> │ ❱ 433 │ │ │ for pmu in perf.pmus(): ╰───────────────────────────────╯ │
> │ 434 │ │ │ │ pmu_name = pmu.name().lower() │
> │ 435 │ │ │ │ pmu_node = pmus.add(pmu_name) │
> │ 436 │ │ │ │ try: │
> ╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
> AttributeError: module 'perf' has no attribute 'pmus'
> root@...ber:~#
>
> Ok, that was with the 'python-perf3' rpm package on fedora 42, trying
> with the new one...
>
> root@...ber:~# export PYTHONPATH=/tmp/build/perf-tools-next/python
> root@...ber:~# ~acme/git/perf-tools-next/tools/perf/python/ilist.py
>
> Cool stuff!
>
> Lots of flashing lights! :-)
>
> Interesting to quickly browse all those events, I like it.
>
> I searched for "wakeup" and stumbled on ftrace:wakeup failures, but that
> should be just a minor adjustment, some exception list:
>
> root@...ber:~# ls -la /sys/kernel/tracing/events/ftrace/wakeup/
> total 0
> drwxr-xr-x. 1 root root 0 Jul 23 16:04 .
> drwxr-xr-x. 1 root root 0 Jul 23 16:04 ..
> -r--r-----. 1 root root 0 Jul 23 16:04 format
> -r--r-----. 1 root root 0 Jul 23 16:19 hist
> root@...ber:~#
> root@...ber:~# ls -la /sys/kernel/tracing/events/sched/sched_wakeup/
> total 0
> drwxr-xr-x. 1 root root 0 Jul 23 16:04 .
> drwxr-xr-x. 1 root root 0 Jul 23 16:04 ..
> -rw-r-----. 1 root root 0 Jul 23 16:19 enable
> -rw-r-----. 1 root root 0 Jul 23 16:19 filter
> -r--r-----. 1 root root 0 Jul 23 16:04 format
> -r--r-----. 1 root root 0 Jul 23 16:19 hist
> -r--r-----. 1 root root 0 Jul 23 16:04 id
> -rw-r-----. 1 root root 0 Jul 23 16:19 trigger
> root@...ber:~#
>
> Do you know how to take text screen shots in textual?
So there's a built-in screen shot thing. Press ctrl+p to bring up the
inbuilt command palette, then select "Save screenshot" which will save
an SVG screenshot. It should be possible to force a lowly terminal and
then grab the characters, I tried but didn't get very far with it.
There are console recorder apps. My preference has just been to grab
regular screenshots and then cut out a PNG. Attaching any kind of
non-standard character or image to an LKML post I think would cause it
to be bounced. I've posted some images here:
ilist working first on events:
https://fosstodon.org/@irogers/114677152263351891
ilist metrics working on hybrid:
https://fosstodon.org/@irogers/114831660998075850
ilist running on WSL on AMD:
https://fosstodon.org/@irogers/114849910913098482
> Apart from the super minor nits, thanks for working on this:
>
> Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com>
Thanks! I think there are still improvements to be had like improving
the layout of the screen, deduplicating PMUs, etc. nothing that can't
be incrementally added. Probably the biggest thing is what to do for
"make install" and packaging it [1]. I think it is a very nice way to
discover what perf can inform you about, and I think everyone I've
talked to prefers doing it with this app rather than trying to get the
same data from regular `perf list`. For example, I was surprised how
much data I could get from WSL.
Thanks,
Ian
[1] (some thoughts on packaging in reply to Namhyung)
https://lore.kernel.org/lkml/CAP-5=fX1j_MdzjqLTYeNGFTWLaQp8Dmbi093QN98b2pNgFcpBA@mail.gmail.com/
> - Arnaldo
Powered by blists - more mailing lists