linux-kernel - Re: [PATCH v4 4/6] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18ef593a-9572-4189-8cd7-2222c8d5e43c@paulmck-laptop>
Date: Wed, 23 Jul 2025 15:51:01 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, rcu@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	bpf@...r.kernel.org
Subject: Re: [PATCH v4 4/6] tracing: Guard __DECLARE_TRACE() use of
 __DO_TRACE_CALL() with SRCU-fast

On Wed, Jul 23, 2025 at 06:29:30PM -0400, Steven Rostedt wrote:
> On Wed, 23 Jul 2025 15:17:52 -0700
> "Paul E. McKenney" <paulmck@...nel.org> wrote:
> 
> > I believe that Steve provided me with the essentials for perf and ftrace,
> > but please check:  f808f53d4e4f ("squash! tracing: Guard __DECLARE_TRACE()
> > use of __DO_TRACE_CALL() with SRCU-fast").
> 
> Note, there's nothing in the ftrace side that requires preemption disabled,
> but it assumes that it is, and adjusts the preempt_count that is recorded
> in the trace event to accommodate it.

Ah, thank you for the clarification.  I agree with your approach as being
a more localized change, with less chance of some forgotten invariant
biting us.  ;-)

							Thanx, Paul