linux-kernel - Re: [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78760c59d6327585dcbd18ca51186c7860a47975.camel@intel.com>
Date: Wed, 23 Jul 2025 23:21:28 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "leitao@...ian.org" <leitao@...ian.org>, "bp@...en8.de" <bp@...en8.de>
CC: lkp <lkp@...el.com>, "oe-kbuild-all@...ts.linux.dev"
	<oe-kbuild-all@...ts.linux.dev>, "xueshuai@...ux.alibaba.com"
	<xueshuai@...ux.alibaba.com>, "acpica-devel@...ts.linux.dev"
	<acpica-devel@...ts.linux.dev>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "Luck, Tony" <tony.luck@...el.com>,
	"james.morse@....com" <james.morse@....com>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>, "oohall@...il.com"
	<oohall@...il.com>, "helgaas@...nel.org" <helgaas@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>, "osandov@...ndov.com"
	<osandov@...ndov.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"lenb@...nel.org" <lenb@...nel.org>, "kernel-team@...a.com"
	<kernel-team@...a.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "hpa@...or.com" <hpa@...or.com>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"mahesh@...ux.ibm.com" <mahesh@...ux.ibm.com>, "guohanjun@...wei.com"
	<guohanjun@...wei.com>, "rafael@...nel.org" <rafael@...nel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "x86@...nel.org"
	<x86@...nel.org>, "Moore, Robert" <robert.moore@...el.com>
Subject: Re: [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors

On Wed, 2025-07-23 at 21:00 +0200, Borislav Petkov wrote:
> On Wed, Jul 23, 2025 at 08:36:52AM -0700, Breno Leitao wrote:
> > Basically there are two approaches, from what I understand:
> > 
> > 	1) mark do_machine_check() as noinstr
> 
> do_machine_check is already noinstr. I think you mean mark
> hwerr_log_error_type() noinstr.
> 
> And yes, you can mark it. hwerr_log_error_type() is not that fascinating
> to allow instrumentation for it.

This option doesn't seem to be able to work because IIRC
hwerr_log_error_type() calls ktime_get_real_seconds() which is not
'noinstr'.

> 
> > 	2) Move hwerr_log_error_type() earlier inside the
> > 	instrumentation_begin() area.
> 
> Or you can do that - that looks like less of an effort btw.