linux-kernel - [PATCH] openprom: Add NULL check for pdev in oprompci2node()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250723040753.3231242-1-chenyuan0y@gmail.com>
Date: Tue, 22 Jul 2025 23:07:53 -0500
From: Chenyuan Yang <chenyuan0y@...il.com>
To: davem@...emloft.net,
	andreas@...sler.com,
	viro@...iv.linux.org.uk,
	chenyuan0y@...il.com
Cc: sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] openprom: Add NULL check for pdev in oprompci2node()

Since pci_get_domain_bus_and_slot() can return NULL,
add NULL check for pdev in oprompci2node().

This change is similar to the fix implemented in commit 9af152dcf1a0
("drm/gma500: Add NULL check for pci_gfx_root in mid_get_vbt_data()").

Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>
---
 drivers/sbus/char/openprom.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/sbus/char/openprom.c b/drivers/sbus/char/openprom.c
index 8643947fee8e..e6f3082569fc 100644
--- a/drivers/sbus/char/openprom.c
+++ b/drivers/sbus/char/openprom.c
@@ -241,6 +241,8 @@ static int oprompci2node(void __user *argp, struct device_node *dp, struct openp
 		pdev = pci_get_domain_bus_and_slot(0,
 						((int *) op->oprom_array)[0],
 						((int *) op->oprom_array)[1]);
+		if (!pdev)
+			return -ENODEV;
 
 		dp = pci_device_to_OF_node(pdev);
 		data->current_node = dp;
-- 
2.34.1