linux-kernel - Re: [PATCH v4 00/14] rv: Add monitors to validate task switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250722205047.621efa7e@gandalf.local.home>
Date: Tue, 22 Jul 2025 20:50:47 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>, Peter
 Zijlstra <peterz@...radead.org>, Nam Cao <namcao@...utronix.de>, Tomas
 Glozar <tglozar@...hat.com>, Juri Lelli <jlelli@...hat.com>, Clark Williams
 <williams@...hat.com>, John Kacur <jkacur@...hat.com>
Subject: Re: [PATCH v4 00/14] rv: Add monitors to validate task switch

On Mon, 21 Jul 2025 10:23:10 +0200
Gabriele Monaco <gmonaco@...hat.com> wrote:

>  Documentation/trace/rv/monitor_sched.rst      | 307 +++++++++++++++---
>  include/linux/rv.h                            |   3 +-
>  include/linux/sched.h                         |   7 +-
>  include/rv/da_monitor.h                       | 129 +++++---
>  include/trace/events/sched.h                  |  12 +-
>  kernel/sched/core.c                           |  13 +-
>  kernel/trace/rv/Kconfig                       |  16 +-
>  kernel/trace/rv/Makefile                      |   6 +-
>  kernel/trace/rv/monitors/{tss => nrp}/Kconfig |  12 +-
>  kernel/trace/rv/monitors/nrp/nrp.c            | 138 ++++++++
>  kernel/trace/rv/monitors/nrp/nrp.h            |  75 +++++
>  kernel/trace/rv/monitors/nrp/nrp_trace.h      |  15 +
>  kernel/trace/rv/monitors/opid/Kconfig         |  19 ++
>  kernel/trace/rv/monitors/opid/opid.c          | 169 ++++++++++
>  kernel/trace/rv/monitors/opid/opid.h          | 104 ++++++
>  .../sncid_trace.h => opid/opid_trace.h}       |   8 +-
>  kernel/trace/rv/monitors/sched/Kconfig        |   1 +
>  kernel/trace/rv/monitors/sched/sched.c        |   3 +-
>  kernel/trace/rv/monitors/sco/sco.c            |   7 +-
>  kernel/trace/rv/monitors/scpd/Kconfig         |   2 +-
>  kernel/trace/rv/monitors/scpd/scpd.c          |   7 +-
>  kernel/trace/rv/monitors/sncid/sncid.c        |  96 ------
>  kernel/trace/rv/monitors/sncid/sncid.h        |  49 ---
>  kernel/trace/rv/monitors/snep/Kconfig         |   2 +-
>  kernel/trace/rv/monitors/snep/snep.c          |   7 +-
>  kernel/trace/rv/monitors/snep/snep.h          |  14 +-
>  kernel/trace/rv/monitors/snroc/snroc.c        |   3 +-
>  .../trace/rv/monitors/{sncid => sssw}/Kconfig |  10 +-
>  kernel/trace/rv/monitors/sssw/sssw.c          | 116 +++++++
>  kernel/trace/rv/monitors/sssw/sssw.h          | 105 ++++++
>  kernel/trace/rv/monitors/sssw/sssw_trace.h    |  15 +
>  kernel/trace/rv/monitors/sts/Kconfig          |  19 ++
>  kernel/trace/rv/monitors/sts/sts.c            | 156 +++++++++
>  kernel/trace/rv/monitors/sts/sts.h            | 117 +++++++
>  .../{tss/tss_trace.h => sts/sts_trace.h}      |   8 +-
>  kernel/trace/rv/monitors/tss/tss.c            |  91 ------
>  kernel/trace/rv/monitors/tss/tss.h            |  47 ---
>  kernel/trace/rv/monitors/wip/Kconfig          |   2 +-
>  kernel/trace/rv/monitors/wip/wip.c            |   3 +-
>  kernel/trace/rv/monitors/wwnr/wwnr.c          |   3 +-
>  kernel/trace/rv/rv_trace.h                    | 114 ++++---

Can you break this up into two patch series? One that modifies the kernel
and one that modifies the tools directory. Linus prefers changes to tools
come in separately to changes in the kernel. So do I as I test them
differently.

Thanks,

-- Steve


>  tools/verification/models/sched/nrp.dot       |  29 ++
>  tools/verification/models/sched/opid.dot      |  35 ++
>  tools/verification/models/sched/sncid.dot     |  18 -
>  tools/verification/models/sched/sssw.dot      |  30 ++
>  tools/verification/models/sched/sts.dot       |  38 +++
>  tools/verification/models/sched/tss.dot       |  18 -
>  tools/verification/rv/src/in_kernel.c         |   4 +-
>  tools/verification/rv/src/rv.c                |   1 +
>  tools/verification/rvgen/rvgen/container.py   |  10 +
>  tools/verification/rvgen/rvgen/dot2c.py       |  20 +-
>  tools/verification/rvgen/rvgen/generator.py   |  16 +-