linux-kernel - RE: [PATCH] drm/bridge: Add null pointer check for ITE IT6263

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346BB82F5A3EBA93493C125865FA@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Wed, 23 Jul 2025 05:19:10 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Chenyuan Yang <chenyuan0y@...il.com>, "victor.liu@....com"
	<victor.liu@....com>, "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>, "rfoss@...nel.org"
	<rfoss@...nel.org>, laurent.pinchart <laurent.pinchart@...asonboard.com>,
	"jonas@...boo.se" <jonas@...boo.se>, "jernej.skrabec@...il.com"
	<jernej.skrabec@...il.com>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"lumag@...nel.org" <lumag@...nel.org>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/bridge: Add null pointer check for ITE IT6263

Hi Chenyuan Yang,

Thanks for the patch.

> -----Original Message-----
> From: Chenyuan Yang <chenyuan0y@...il.com>
> Sent: 22 July 2025 21:41
> Subject: [PATCH] drm/bridge: Add null pointer check for ITE IT6263
> 
> drm_atomic_get_new_connector_for_encoder and drm_atomic_get_new_connector_state could return Null.
> Thus, add the null pointer check for them with a similar format with it6505_bridge_atomic_enable in
> ITE IT6505.
> 
> Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>
> Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")

Normally Fixes should be above Sb tag.

> ---
>  drivers/gpu/drm/bridge/ite-it6263.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
> index a3a63a977b0a..3a20b2088bf9 100644
> --- a/drivers/gpu/drm/bridge/ite-it6263.c
> +++ b/drivers/gpu/drm/bridge/ite-it6263.c
> @@ -590,15 +590,28 @@ static void it6263_bridge_atomic_enable(struct drm_bridge *bridge,
>  	struct drm_connector *connector;
>  	bool is_stable = false;
>  	struct drm_crtc *crtc;
> +	struct drm_connector_state *conn_state;

Please arrange it in reverse X-mas tree fashion.

>  	unsigned int val;
>  	bool pclk_high;
>  	int i, ret;
> 
>  	connector = drm_atomic_get_new_connector_for_encoder(state,
>  							     bridge->encoder);
> -	crtc = drm_atomic_get_new_connector_state(state, connector)->crtc;
> +	if (WARN_ON(!connector))

Why WARN_ON everywhere? Can we use dev_err instead?

Cheers,
Biju

> +		return;
> +
> +	conn_state = drm_atomic_get_new_connector_state(state, connector);
> +	if (WARN_ON(!conn_state))
> +		return;
> +
> +	crtc = conn_state->crtc;
>  	crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
> +	if (WARN_ON(!crtc_state))
> +		return;
> +
>  	mode = &crtc_state->adjusted_mode;
> +	if (WARN_ON(!mode))
> +		return;
> 
>  	regmap_write(regmap, HDMI_REG_HDMI_MODE, TX_HDMI_MODE);
> 
> --
> 2.34.1