linux-kernel - Re: [PATCH -resend] drm/msm: use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ec295d5-19a2-4a3e-b246-1eb5860560ac@kernel.org>
Date: Wed, 23 Jul 2025 08:09:41 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Dmitry Baryshkov <lumag@...nel.org>
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de,
 Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Sean Paul <sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org
Subject: Re: [PATCH -resend] drm/msm: use dev_fwnode()

Hmm, I got: "Dmitry Baryshkov no longer works for Linaro.". "To:" field 
fixed using @kernel.org address (was in Cc).

On 23. 07. 25, 7:55, Jiri Slaby (SUSE) wrote:
> irq_domain_create_simple() takes fwnode as the first argument. It can be
> extracted from the struct device using dev_fwnode() helper instead of
> using of_node with of_fwnode_handle().
> 
> So use the dev_fwnode() helper.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>
> Cc: Dmitry Baryshkov <lumag@...nel.org>
> Cc: Sean Paul <sean@...rly.run>
> Cc: Marijn Suijten <marijn.suijten@...ainline.org>
> Cc: David Airlie <airlied@...il.com>
> Cc: Simona Vetter <simona@...ll.ch>
> 
> ---
> 
> Cc: linux-arm-msm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> ---
>   drivers/gpu/drm/msm/msm_mdss.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
> index 1f5fe7811e01..ec7d83831b83 100644
> --- a/drivers/gpu/drm/msm/msm_mdss.c
> +++ b/drivers/gpu/drm/msm/msm_mdss.c
> @@ -154,8 +154,7 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss)
>   
>   	dev = msm_mdss->dev;
>   
> -	domain = irq_domain_create_linear(of_fwnode_handle(dev->of_node), 32,
> -			&msm_mdss_irqdomain_ops, msm_mdss);
> +	domain = irq_domain_create_linear(dev_fwnode(dev), 32, &msm_mdss_irqdomain_ops, msm_mdss);
>   	if (!domain) {
>   		dev_err(dev, "failed to add irq_domain\n");
>   		return -EINVAL;


-- 
js
suse labs