linux-kernel - Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cabdf172-8de8-4b26-b7b6-ab97f940428b@kernel.org>
Date: Wed, 23 Jul 2025 08:45:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Erik Beck <xunil@...omasoft.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)

On 21/07/2025 22:17, Erik Beck wrote:
> 
> Signed-off-by: Erik Beck <xunil@...omasoft.com>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


Please version your patches correctly, e.g. use b4 or git format-patch
-vX, and add changelog in cover letter or under '---' of individual
patches describing changes from previous version.


> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../rockchip/rk3568-linkstar-h68k-1432v1.dts  | 740 ++++++++++++++++++
>  2 files changed, 741 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> 

...

> +        hdmi-con {
> +                compatible = "hdmi-connector";
> +                type = "a";
> +
> +                port {
> +                        hdmi_con_in: endpoint {
> +                                remote-endpoint = <&hdmi_out_con>;
> +                        };
> +                };
> +        };
> +
> +        gpio-keys {
> +                compatible = "gpio-keys";
> +                pinctrl-0 = <&reset_button_pin>;
> +                pinctrl-names = "default";
> +
> +        /* Middle inset/recessed button,
> +                  marked by clockwise arrow/circle */

Messed indentation


Best regards,
Krzysztof