linux-kernel - Re: [PATCH v2 2/2] binder: Use seq_buf in binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507230032.742E5A52E6@keescook>
Date: Wed, 23 Jul 2025 00:32:53 -0700
From: Kees Cook <kees@...nel.org>
To: Tiffany Yang <ynaffit@...gle.com>
Cc: linux-kernel@...r.kernel.org, Carlos Llamas <cmllamas@...gle.com>,
	Joel Fernandes <joelagnelf@...dia.com>, kernel-team@...roid.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>
Subject: Re: [PATCH v2 2/2] binder: Use seq_buf in binder_alloc kunit tests

On Tue, Jul 22, 2025 at 04:45:07PM -0700, Tiffany Yang wrote:
> Replace instances of snprintf with seq_buf functions, as suggested by
> Kees [1].
> 
> [1] https://lore.kernel.org/all/202507160743.15E8044@keescook/
> 
> Fixes: d1934ed9803c ("binder: encapsulate individual alloc test cases")
> Suggested-by: Kees Cook <kees@...nel.org>
> Cc: Joel Fernandes <joelagnelf@...dia.com>
> Signed-off-by: Tiffany Yang <ynaffit@...gle.com>
> ---
> This patch is based on top of char-misc-next.
> ---
>  drivers/android/tests/binder_alloc_kunit.c | 46 ++++++++++------------
>  1 file changed, 21 insertions(+), 25 deletions(-)

Yay, always nice to see using an alternative API results in fewer lines! :)

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook