linux-kernel - Re: [PATCH v2 01/15] dt-bindings: display: sprd: adapt for UMS9230 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250723-eager-shark-of-fruition-e3237e@kuoka>
Date: Wed, 23 Jul 2025 09:50:46 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Otto Pflüger <otto.pflueger@...cue.de>
Cc: David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Orson Zhai <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, 
	Chunyan Zhang <zhang.lyra@...il.com>, Kevin Tang <kevin.tang@...soc.com>, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/15] dt-bindings: display: sprd: adapt for UMS9230
 support

On Tue, Jul 22, 2025 at 04:41:03PM +0200, Otto Pflüger wrote:
> Add the compatible strings for the display controller found in the
> UMS9230 SoC and introduce more descriptive names for the clocks.
> 
> Signed-off-by: Otto Pflüger <otto.pflueger@...cue.de>
> ---
>  .../bindings/display/sprd/sprd,sharkl3-dpu.yaml    | 24 +++++++++++++++-------
>  .../display/sprd/sprd,sharkl3-dsi-host.yaml        | 15 ++++++++++----
>  2 files changed, 28 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml
> index 8c52fa0ea5f8ee2149ebf1d4b0d5b052832e3d97..7f34652080b22e7b7072a709fd390a72375110ef 100644
> --- a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml
> +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml
> @@ -16,7 +16,12 @@ description: |
>  
>  properties:
>    compatible:
> -    const: sprd,sharkl3-dpu
> +    oneOf:
> +      - items:
> +          - enum:
> +              - sprd,ums9230-dpu
> +          - const: sprd,sharkl3-dpu
> +      - const: sprd,sharkl3-dpu
>  
>    reg:
>      maxItems: 1
> @@ -28,9 +33,14 @@ properties:
>      maxItems: 2
>  
>    clock-names:
> -    items:
> -      - const: clk_src_128m
> -      - const: clk_src_384m
> +    oneOf:
> +      - deprecated: true
> +        items:
> +          - const: clk_src_128m
> +          - const: clk_src_384m
> +      - items:
> +          - const: core
> +          - const: dpi

This should be rather a separate change with its own explanation. You
are affecting/changing existing binding and new device bringup should
usually not affect it. Same with second file.

Changes are fine, just split to clearly see the impact on existing
binding.

Best regards,
Krzysztof