linux-kernel - Re: [PATCH v1] tools/rtla: Consolidate common parameters into shared structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250722200413.4a3b3777@gandalf.local.home>
Date: Tue, 22 Jul 2025 20:04:13 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Tomas Glozar <tglozar@...hat.com>, John Kacur <jkacur@...hat.com>, Eder
 Zulian <ezulian@...hat.com>, Dan Carpenter <dan.carpenter@...aro.org>,
 Gabriele Monaco <gmonaco@...hat.com>, Jan Stancek <jstancek@...hat.com>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH v1] tools/rtla: Consolidate common parameters into
 shared structure

On Tue,  1 Jul 2025 09:03:14 +0300
Costa Shulyupin <costa.shul@...hat.com> wrote:

> timerlat_params and osnoise_params structures contain 17 identical
> fields.
> 
> Introduce a common_params structure and move those fields into it to
> eliminate the code duplication and improve maintainability.

I have no preference about this patch, but would like an acked-by or
reviewed-by from Tomas and/or Gabriele.

Thanks,

-- Steve


> 
> Signed-off-by: Costa Shulyupin <costa.shul@...hat.com>
> ---
>  tools/tracing/rtla/src/osnoise.c       |  24 ++---
>  tools/tracing/rtla/src/osnoise.h       |  19 +---
>  tools/tracing/rtla/src/osnoise_hist.c  | 112 ++++++++++-----------
>  tools/tracing/rtla/src/osnoise_top.c   | 102 +++++++++----------
>  tools/tracing/rtla/src/timerlat.c      |  24 ++---
>  tools/tracing/rtla/src/timerlat.h      |  19 +---
>  tools/tracing/rtla/src/timerlat_bpf.c  |   4 +-
>  tools/tracing/rtla/src/timerlat_hist.c | 129 +++++++++++++------------
>  tools/tracing/rtla/src/timerlat_top.c  | 121 +++++++++++------------
>  tools/tracing/rtla/src/utils.h         |  31 ++++++
>  10 files changed, 292 insertions(+), 293 deletions(-)
>