linux-kernel - Re: [PATCH] mm: add stack trace when bad rss-counter state is detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <119c3422-0bb1-4806-b81c-ccf1c7aeba4d@redhat.com>
Date: Wed, 23 Jul 2025 10:05:36 +0200
From: David Hildenbrand <david@...hat.com>
To: Xuanye Liu <liuqiye2025@....com>, Kees Cook <kees@...nel.org>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: add stack trace when bad rss-counter state is
 detected

On 23.07.25 09:45, Xuanye Liu wrote:
> 
> 在 2025/7/23 15:31, Kees Cook 写道:
>> On Wed, Jul 23, 2025 at 03:23:49PM +0800, Xuanye Liu wrote:
>>> The check_mm() function verifies the correctness of rss counters in
>>> struct mm_struct. Currently, it only prints an alert when a bad
>>> rss-counter state is detected, but lacks sufficient context for
>>> debugging.
>>>
>>> This patch adds a dump_stack() call to provide a stack trace when
>>> the rss-counter state is invalid. This helps developers identify
>>> where the corrupted mm_struct is being checked and trace the
>>> underlying cause of the inconsistency.
>> Why not just convert the pr_alert to a WARN?
> Good idea! I'll gather more feedback from others and then update to v2.

Makes sense to me.

-- 
Cheers,

David / dhildenb