linux-kernel - Re: [PATCH 3/4] dt-bindings: display: imx: add binding for i.MX8MP HDMI PAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adf144c9-3c36-4806-b1bc-9122d511f338@nxp.com>
Date: Wed, 23 Jul 2025 17:01:11 +0800
From: Liu Ying <victor.liu@....com>
To: Shengjiu Wang <shengjiu.wang@...il.com>
Cc: Shengjiu Wang <shengjiu.wang@....com>, andrzej.hajda@...el.com,
 neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 lumag@...nel.org, dianders@...omium.org, cristian.ciocaltea@...labora.com,
 luca.ceresoli@...tlin.com, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, devicetree@...r.kernel.org,
 l.stach@...gutronix.de
Subject: Re: [PATCH 3/4] dt-bindings: display: imx: add binding for i.MX8MP
 HDMI PAI

On 07/23/2025, Shengjiu Wang wrote:
> On Tue, Jul 22, 2025 at 3:16 PM Liu Ying <victor.liu@....com> wrote:
>>
>> Hi Shengjiu,
>>
>> On 07/18/2025, Shengjiu Wang wrote:
>>> Add binding for the i.MX8MP HDMI parallel Audio interface block.
>>> As this port is linked to imx8mp-hdmi-tx, add port@2 in
>>> fsl,imx8mp-hdmi-tx.yaml document.
>>>
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
>>> ---
>>>  .../display/bridge/fsl,imx8mp-hdmi-tx.yaml    | 13 ++++
>>>  .../display/imx/fsl,imx8mp-hdmi-pai.yaml      | 61 +++++++++++++++++++
>>>  2 files changed, 74 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pai.yaml

[...]

>>> +properties:
>>
>> In i.MX8MP TRM, HTX_PAI block diagram mentions an APB interface.
>> Does it mean a clock is needed?
> 
> The APB clock is bound with the power domain, so no need to add it here.

That depends on OS's power domain driver implementation.
>From DT's point of view, the APB clock should be a property here.

> 
>>
>>> +  compatible:
>>> +    const: fsl,imx8mp-hdmi-pai
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>> +  port:
>>> +    $ref: /schemas/graph.yaml#/properties/port
>>> +    description: Output to the HDMI TX controller.
>>> +    unevaluatedProperties: false
>>
>> Why do you need this line?
> 
> per my understanding, this line can be added or removed.

I'd choose to drop it :)

[...]

-- 
Regards,
Liu Ying