linux-kernel - Re: [PATCH] tracing: sched: Hide numa events under CONFIG_NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <708b26cc-e888-44d1-a7eb-ba37dea23a89@linux.ibm.com>
Date: Wed, 23 Jul 2025 15:14:26 +0530
From: Shrikanth Hegde <sshegde@...ux.ibm.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux trace kernel <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: sched: Hide numa events under
 CONFIG_NUMA_BALANCING



On 6/12/25 19:35, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The events sched_move_numa, sched_stick_numa and sched_swap_numa are only
> called when CONFIG_NUMA_BALANCING is configured. As each event can take up
> to 5K of memory in text and meta data regardless if they are used or not,
> they should not be defined when used.

they should be defined when used?

> 
> Move the #ifdef CONFIG_NUMA_BALANCING to hide these events as well.
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
> Note, I will be adding code soon that will make unused events cause a warning.
> 
>   include/trace/events/sched.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index 4e6b2910cec3..0243f32e068a 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -628,6 +628,7 @@ TRACE_EVENT(sched_process_hang,
>   );
>   #endif /* CONFIG_DETECT_HUNG_TASK */
>   
> +#ifdef CONFIG_NUMA_BALANCING
>   /*
>    * Tracks migration of tasks from one runqueue to another. Can be used to
>    * detect if automatic NUMA balancing is bouncing between nodes.
> @@ -720,7 +721,6 @@ DEFINE_EVENT(sched_numa_pair_template, sched_swap_numa,
>   	TP_ARGS(src_tsk, src_cpu, dst_tsk, dst_cpu)
>   );
>   
> -#ifdef CONFIG_NUMA_BALANCING
>   #define NUMAB_SKIP_REASON					\
>   	EM( NUMAB_SKIP_UNSUITABLE,		"unsuitable" )	\
>   	EM( NUMAB_SKIP_SHARED_RO,		"shared_ro" )	\


Reviewed-by: Shrikanth Hegde <sshegde@...ux.ibm.com>