linux-kernel - Re: [PATCH v2 4/7] phy: qualcomm: eusb2-repeater: Migrate to devm_spmi_subdevice_alloc_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507231743.Z1ToUg4r-lkp@intel.com>
Date: Wed, 23 Jul 2025 18:02:25 +0800
From: kernel test robot <lkp@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	sboyd@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, jic23@...nel.org, dlechner@...libre.com,
	nuno.sa@...log.com, andy@...nel.org, arnd@...db.de,
	gregkh@...uxfoundation.org, srini@...nel.org, vkoul@...nel.org,
	kishon@...nel.org, sre@...nel.org, krzysztof.kozlowski@...aro.org,
	u.kleine-koenig@...libre.com,
	angelogioacchino.delregno@...labora.com,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-pm@...r.kernel.org, kernel@...labora.com, wenst@...omium.org,
	casey.connolly@...aro.org
Subject: Re: [PATCH v2 4/7] phy: qualcomm: eusb2-repeater: Migrate to
 devm_spmi_subdevice_alloc_and_add()

Hi AngeloGioacchino,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20250722]
[cannot apply to jic23-iio/togreg sre-power-supply/for-next char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.16-rc7 v6.16-rc6 v6.16-rc5 v6.16-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/spmi-Implement-spmi_subdevice_alloc_and_add-and-devm-variant/20250722-181911
base:   next-20250722
patch link:    https://lore.kernel.org/r/20250722101317.76729-5-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v2 4/7] phy: qualcomm: eusb2-repeater: Migrate to devm_spmi_subdevice_alloc_and_add()
config: sparc-randconfig-001-20250723 (https://download.01.org/0day-ci/archive/20250723/202507231743.Z1ToUg4r-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250723/202507231743.Z1ToUg4r-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507231743.Z1ToUg4r-lkp@intel.com/

All errors (new ones prefixed by >>):

   sparc-linux-ld: drivers/phy/qualcomm/phy-qcom-eusb2-repeater.o: in function `eusb2_repeater_probe':
>> drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c:228: undefined reference to `devm_spmi_subdevice_alloc_and_add'
>> sparc-linux-ld: drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c:236: undefined reference to `__devm_regmap_init_spmi_ext'


vim +228 drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c

   193	
   194	static int eusb2_repeater_probe(struct platform_device *pdev)
   195	{
   196		struct regmap_config eusb2_regmap_config = {
   197			.reg_bits = 16,
   198			.val_bits = 8,
   199			.max_register = 0x100,
   200			.fast_io = true,
   201		};
   202		struct spmi_device *sparent;
   203		struct eusb2_repeater *rptr;
   204		struct spmi_subdevice *sub_sdev;
   205		struct device *dev = &pdev->dev;
   206		struct phy_provider *phy_provider;
   207		struct device_node *np = dev->of_node;
   208		int ret;
   209	
   210		if (!dev->parent)
   211			return -ENODEV;
   212	
   213		rptr = devm_kzalloc(dev, sizeof(*rptr), GFP_KERNEL);
   214		if (!rptr)
   215			return -ENOMEM;
   216	
   217		rptr->dev = dev;
   218		dev_set_drvdata(dev, rptr);
   219	
   220		rptr->cfg = of_device_get_match_data(dev);
   221		if (!rptr->cfg)
   222			return -EINVAL;
   223	
   224		sparent = to_spmi_device(dev->parent);
   225		if (!sparent)
   226			return -ENODEV;
   227	
 > 228		sub_sdev = devm_spmi_subdevice_alloc_and_add(dev, sparent);
   229		if (IS_ERR(sub_sdev))
   230			return PTR_ERR(sub_sdev);
   231	
   232		ret = of_property_read_u32(np, "reg", &eusb2_regmap_config.reg_base);
   233		if (ret < 0)
   234			return ret;
   235	
 > 236		rptr->regmap = devm_regmap_init_spmi_ext(&sub_sdev->sdev, &eusb2_regmap_config);
   237		if (IS_ERR(rptr->regmap))
   238			return -ENODEV;
   239	
   240		ret = eusb2_repeater_init_vregs(rptr);
   241		if (ret < 0) {
   242			dev_err(dev, "unable to get supplies\n");
   243			return ret;
   244		}
   245	
   246		rptr->phy = devm_phy_create(dev, np, &eusb2_repeater_ops);
   247		if (IS_ERR(rptr->phy)) {
   248			dev_err(dev, "failed to create PHY: %d\n", ret);
   249			return PTR_ERR(rptr->phy);
   250		}
   251	
   252		phy_set_drvdata(rptr->phy, rptr);
   253	
   254		phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
   255		if (IS_ERR(phy_provider))
   256			return PTR_ERR(phy_provider);
   257	
   258		return 0;
   259	}
   260	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki