linux-kernel - Re: [PATCH 2/3] PCI: Add PCI vendor ID for ASMedia USB4 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eda6c473-dde8-4a56-8422-278971fa970f@amd.com>
Date: Wed, 23 Jul 2025 15:46:27 +0530
From: "Rangoju, Raju" <raju.rangoju@....com>
To: Bjorn Helgaas <helgaas@...nel.org>, Chloe_Chen@...edia.com.tw
Cc: linux-usb@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, andreas.noever@...il.com,
 michael.jamet@...el.com, westeri@...nel.org, YehezkelShB@...il.com,
 bhelgaas@...gle.com, Sanath.S@....com
Subject: Re: [PATCH 2/3] PCI: Add PCI vendor ID for ASMedia USB4 devices



On 7/23/2025 12:44 AM, Bjorn Helgaas wrote:
> On Tue, Jul 22, 2025 at 11:20:25PM +0530, Raju Rangoju wrote:
>> Add a new PCI vendor ID (PCI_VENDOR_ID_ASMEDIA_USB4) for ASMedia
>> USB4 devices. This change enables proper identification and support
>> for ASMedia USB4 hardware in the kernel.
>>
>> Co-developed-by: Sanath S <Sanath.S@....com>
>> Signed-off-by: Sanath S <Sanath.S@....com>
>> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
>> ---
>>   include/linux/pci_ids.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index e2d71b6fdd84..3397954ce96e 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2592,6 +2592,7 @@
>>   #define PCI_SUBDEVICE_ID_QEMU            0x1100
>>   
>>   #define PCI_VENDOR_ID_ASMEDIA		0x1b21
>> +#define PCI_VENDOR_ID_ASMEDIA_USB4	0x174C
>>   
>>   #define PCI_VENDOR_ID_REDHAT		0x1b36
> 
> Sort by Vendor ID value (not the name), per the comment at the top.
> 
> Use lower-case hex to match style (not universally observed, but
> close).

Sure Bjorn, I'll address these changes in v2.

> 
> Per https://pcisig.com/membership/member-companies, 0x174c is not
> reserved, although the same is true for 0x1b21 and many other Vendor
> IDs.  Do you know the history of 0x174c and 0x1b21, or why these don't
> show up as reserved?

Chloe_Chen@...edia.com.tw, could you please comment here?

> 
> With these,
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Bjorn