linux-kernel - Re: [PATCH v5] bpftool: Add CET-aware symbol matching for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a55fde07-9320-46b0-bf7c-a2fdfb7c79b2@kernel.org>
Date: Wed, 23 Jul 2025 11:24:14 +0100
From: Quentin Monnet <qmo@...nel.org>
To: chenyuan <chenyuan_fl@....com>, ast@...nel.org, daniel@...earbox.net,
 andrii@...nel.org, yonghong.song@...ux.dev
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 Yuan Chen <chenyuan@...inos.cn>
Subject: Re: [PATCH v5] bpftool: Add CET-aware symbol matching for x86_64
 architectures

Your message had a
"Reply-To: <aef2617b-ce03-4830-96a7-39df0c93aaad@...nel.org>" header, I
ignored it. I believe you meant to have In-Reply-To: instead.


2025-07-23 10:20 UTC+0800 ~ chenyuan_fl@....com
> From: Yuan Chen <chenyuan@...inos.cn>
> 
> Adjust symbol matching logic to account for Control-flow Enforcement
> Technology (CET) on x86_64 systems. CET prefixes functions with
> a 4-byte 'endbr' instruction, shifting the actual hook entry point to
> symbol + 4.
> 
> Changed in PATCH v4:
> * Refactor repeated code into a function.
> * Add detection for the x86 architecture.
> 
> Changed int PATH v5:
> * Remove detection for the x86 architecture.
> 
> Signed-off-by: Yuan Chen <chenyuan@...inos.cn>
> ---


Looks good from my side, thank you!

Reviewed-by: Quentin Monnet <qmo@...nel.org>

Probably worth waiting for Yonghong's ack as well before merging this patch.