lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <39c72bcf-d9d4-4f07-856d-4cf27e55cf36@lucifer.local>
Date: Wed, 23 Jul 2025 11:50:22 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: David Hildenbrand <david@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v2] MAINTAINERS: add MM MISC section, add missing files
 to MISC and CORE

On Wed, Jul 23, 2025 at 12:36:49PM +0200, David Hildenbrand wrote:
> On 23.07.25 11:58, Lorenzo Stoakes wrote:
> > Add a MEMORY MANAGEMENT - MISC section to contain files that are not described
> > by other sections, moving all but the catch-all mm/ and tools/mm/ from MEMORY
> > MANAGEMENT to MEMORY MANAGEMENT - CORE and MEMORY MANAGEMENT - MISC as
> > appropriate.
>
> Curious: do we need the catch-all because of untracked files, or because of
> future files?

Untracked was the intent, future files should be added to MAINTAINERS
(maybe I need to write a script for this somewhere...).

I guess the intent was so Andrew gets pinged on everything whether tracked
elsewhere or not?

>
> >
> > In both sections add remaining missing files. At this point, with the other
> > recent MAINTAINERS changes, this should now mean that every memory
> > management-related file has a section and assigned maintainers/reviewers.
> >
> > Finally, we copy across the maintainers/reviewers from MEMORY MANAGEMENT -
> > CORE to MEMORY MANAGEMENT - MISC, as it seems the two are sufficiently
> > related for this to be sensible.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> > Acked-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> > ---
> >
> > v2:
> > * Propagate ack (thanks Mike!)
> > * Retain MEMORY MANAGEMENT section to contain the global mm/ and tools/mm/
> >    directories and remove from MEMORY MANAGEMENT - MISC section, I misunderstood
> >    how these catch-alls would work. As reported by Vlastimil.
> > * Update cover letter and subject to reflect the above.
> >
> > v1:
> > https://lore.kernel.org/all/20250722192704.164758-1-lorenzo.stoakes@oracle.com/
> >
> >
> >   MAINTAINERS | 68 ++++++++++++++++++++++++++++++++++++++++++-----------
> >   1 file changed, 54 insertions(+), 14 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 507a999f1955..5a9d4c57add4 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15741,22 +15741,8 @@ S:	Maintained
> >   W:	http://www.linux-mm.org
> >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> >   T:	quilt git://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new
> > -F:	Documentation/admin-guide/mm/
> > -F:	Documentation/mm/
> > -F:	include/linux/gfp.h
> > -F:	include/linux/gfp_types.h
> > -F:	include/linux/memory_hotplug.h
> > -F:	include/linux/memory-tiers.h
> > -F:	include/linux/mempolicy.h
> > -F:	include/linux/mempool.h
> > -F:	include/linux/mmzone.h
> > -F:	include/linux/mmu_notifier.h
> > -F:	include/linux/pagewalk.h
> > -F:	include/trace/events/ksm.h
> >   F:	mm/
> >   F:	tools/mm/
> > -F:	tools/testing/selftests/mm/
> > -N:	include/linux/page[-_]*
> >
> >   MEMORY MANAGEMENT - CORE
> >   M:	Andrew Morton <akpm@...ux-foundation.org>
> > @@ -15771,18 +15757,32 @@ L:	linux-mm@...ck.org
> >   S:	Maintained
> >   W:	http://www.linux-mm.org
> >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	include/linux/gfp.h
> > +F:	include/linux/gfp_types.h
> >   F:	include/linux/memory.h
> >   F:	include/linux/mm.h
> >   F:	include/linux/mm_*.h
> > +F:	include/linux/mmzone.h
> >   F:	include/linux/mmdebug.h
> >   F:	include/linux/pagewalk.h
> >   F:	kernel/fork.c
> >   F:	mm/Kconfig
> >   F:	mm/debug.c
> > +F:	mm/folio-compat.c
> > +F:	mm/highmem.c
> >   F:	mm/init-mm.c
> > +F:	mm/internal.h
> > +F:	mm/maccess.c
> >   F:	mm/memory.c
> > +F:	mm/mmzone.c
> >   F:	mm/pagewalk.c
> > +F:	mm/pgtable-generic.c
> > +F:	mm/sparse-vmemmap.c
> > +F:	mm/sparse.c
> >   F:	mm/util.c
> > +F:	mm/vmpressure.c
> > +F:	mm/vmstat.c
> > +N:	include/linux/page[-_]*
> >
> >   MEMORY MANAGEMENT - EXECMEM
> >   M:	Andrew Morton <akpm@...ux-foundation.org>
> > @@ -15844,6 +15844,46 @@ F:	mm/mempolicy.c
> >   F:	mm/migrate.c
> >   F:	mm/migrate_device.c
> >
> > +MEMORY MANAGEMENT - MISC
> > +M:	Andrew Morton <akpm@...ux-foundation.org>
> > +M:	David Hildenbrand <david@...hat.com>
> > +R:	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> > +R:	Liam R. Howlett <Liam.Howlett@...cle.com>
> > +R:	Vlastimil Babka <vbabka@...e.cz>
> > +R:	Mike Rapoport <rppt@...nel.org>
> > +R:	Suren Baghdasaryan <surenb@...gle.com>
> > +R:	Michal Hocko <mhocko@...e.com>
> > +L:	linux-mm@...ck.org
> > +S:	Maintained
> > +W:	http://www.linux-mm.org
> > +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	Documentation/admin-guide/mm/
> > +F:	Documentation/mm/
> > +F:	include/linux/memory-tiers.h
> > +F:	include/linux/mempolicy.h
>
> That is already under "MEMORY MANAGEMENT - MEMORY POLICY AND MIGRATION"
>
> > +F:	include/linux/mempool.h
> > +F:	include/linux/memremap.h
>
> That will be MEMORY_HOTPLUG, right?
>
> > +F:	include/linux/mmu_notifier.h
> > +F:	include/trace/events/ksm.h
>
> This is already in the KSM section.

Ack will send a fix-patch.

The ordering of these patches and sending all separate has made this fun :)
I felt best way, so one update with issues doesn't hold up others.

I am _very keen_ to get this done and dusted and never look at MAINTAINERS
again :P

>
> > +F:	mm/backing-dev.c
> > +F:	mm/cma.c
> > +F:	mm/cma_debug.c
> > +F:	mm/cma_sysfs.c
> > +F:	mm/dmapool.c
> > +F:	mm/dmapool_test.c
> > +F:	mm/early_ioremap.c
> > +F:	mm/fadvise.c
> > +F:	mm/io-mapping.c
> > +F:	mm/ioremap.c
> > +F:	mm/mapping_dirty_helpers.c
> > +F:	mm/memory-tiers.c
> > +F:	mm/mmu_notifier.c
> > +F:	mm/page_idle.c
> > +F:	mm/pgalloc-track.h
> > +F:	mm/process_vm_access.c
> > +F:	mm/ptdump.c
> > +F:	tools/testing/selftests/mm/
>
> Kind-of a catch-all as well.

Yeah but far smaller and we really should be pinged on these IMO. Probably
we need more work to add tests to relevant sections.

MISC is sort of a 'everything else' and we can update this over time.

I rather get us to the point where _everything_ or more-or-less
_everything_ is in sections and then iteratively fix up as we go rather
than leave something out.

>
>
> --
> Cheers,
>
> David / dhildenb
>

Thanks, Lorenzo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ