linux-kernel - Re: [PATCH] rust: sync: extend module documentation of aref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72=UqCnGzRgjigtEmsyh=7Ky7q6oNZRu3xZXummOTB2pTg@mail.gmail.com>
Date: Wed, 23 Jul 2025 12:51:39 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Daniel Sedlak <daniel@...lak.dev>
Cc: Benno Lossin <lossin@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, 
	Shankari Anand <shankari.ak0208@...il.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: sync: extend module documentation of aref

On Wed, Jul 23, 2025 at 12:25 PM Daniel Sedlak <daniel@...lak.dev> wrote:
>
> It got me curios. Why is it required to declare the doc reference for
> Arc and Arc<T>, but not ARef<MyType> and ARef<T>?
>
> Is it because ARef is in file scope but not the Arc?
>
> If so, you could just add
>
>         use crate::sync::Arc;

That would be unused -- i.e. we don't add imports in the actual code
only for docs.

The compiler also warns about it (`unused_imports`).

Thanks!

Cheers,
Miguel