linux-kernel - Re: [PATCH] dmaengine: nbpfaxi: Add missing check after DMA map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIDQSA3JFbyyaWkM@vaman>
Date: Wed, 23 Jul 2025 17:36:32 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@....de>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: nbpfaxi:  Add missing check after DMA map

On 07-07-25, 09:57, Thomas Fourier wrote:
> The DMA map functions can fail and should be tested for errors.
> If the mapping fails, unmap and return an error.

Pls change this to dmaengine: xxx that is the subsystem name as show in
the Fixes tag that you picked up below

Meanwhile this does not apply for me, pls rebase

> 
> Fixes: b45b262cefd5 ("dmaengine: add a driver for AMBA AXI NBPF DMAC IP cores")
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>
> ---
>  drivers/dma/nbpfaxi.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c
> index 0d6324c4e2be..0b75bb122898 100644
> --- a/drivers/dma/nbpfaxi.c
> +++ b/drivers/dma/nbpfaxi.c
> @@ -711,6 +711,9 @@ static int nbpf_desc_page_alloc(struct nbpf_channel *chan)
>  		list_add_tail(&ldesc->node, &lhead);
>  		ldesc->hwdesc_dma_addr = dma_map_single(dchan->device->dev,
>  					hwdesc, sizeof(*hwdesc), DMA_TO_DEVICE);
> +		if (dma_mapping_error(dchan->device->dev,
> +				      ldesc->hwdesc_dma_addr))
> +			goto unmap_error;
>  
>  		dev_dbg(dev, "%s(): mapped 0x%p to %pad\n", __func__,
>  			hwdesc, &ldesc->hwdesc_dma_addr);
> @@ -737,6 +740,16 @@ static int nbpf_desc_page_alloc(struct nbpf_channel *chan)
>  	spin_unlock_irq(&chan->lock);
>  
>  	return ARRAY_SIZE(dpage->desc);
> +
> +unmap_error:
> +	while (i--) {
> +		ldesc--; hwdesc--;
> +
> +		dma_unmap_single(dchan->device->dev, ldesc->hwdesc_dma_addr,
> +				 sizeof(hwdesc), DMA_TO_DEVICE);
> +	}
> +
> +	return -ENOMEM;
>  }
>  
>  static void nbpf_desc_put(struct nbpf_desc *desc)
> -- 
> 2.43.0

-- 
~Vinod