linux-kernel - RE: [PATCH] Bluetooth: btintel_pcie: Drop pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB7585C9C53264028687071050F55FA@PH0PR11MB7585.namprd11.prod.outlook.com>
Date: Wed, 23 Jul 2025 12:43:23 +0000
From: "K, Kiran" <kiran.k@...el.com>
To: Salah Triki <salah.triki@...il.com>, Marcel Holtmann
	<marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)

Hi Luiz,

>-----Original Message-----
>From: Salah Triki <salah.triki@...il.com>
>Sent: Thursday, July 17, 2025 8:55 AM
>To: Marcel Holtmann <marcel@...tmann.org>; Luiz Augusto von Dentz
><luiz.dentz@...il.com>; linux-bluetooth@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Cc: salah.triki@...il.com
>Subject: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)
>
>Drop pci_set_drvdata(pdev, NULL) in the remove function of the pci driver
>since it is useless, the data is not accessible when the driver is removed.
>
>Signed-off-by: Salah Triki <salah.triki@...il.com>

Tested-by: Kiran K <kiran.k@...el.com>
>---
> drivers/bluetooth/btintel_pcie.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
>index e1c688dd2d45..28fa4ca3199a 100644
>--- a/drivers/bluetooth/btintel_pcie.c
>+++ b/drivers/bluetooth/btintel_pcie.c
>@@ -2339,8 +2339,6 @@ static void btintel_pcie_remove(struct pci_dev
>*pdev)
> 	btintel_pcie_free(data);
>
> 	pci_clear_master(pdev);
>-
>-	pci_set_drvdata(pdev, NULL);
> }
>
> #ifdef CONFIG_DEV_COREDUMP
>--
>2.43.0
>
Thanks,
Kiran