linux-kernel - Re: [PATCH v5 06/10] pinctrl: meson: Fix typo in device table macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d02c400f-d159-451c-b4ac-745e74986591@linaro.org>
Date: Thu, 24 Jul 2025 16:09:53 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Alexey Gladkov <legion@...nel.org>, Masahiro Yamada
 <masahiroy@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>,
 Luis Chamberlain <mcgrof@...nel.org>, Sami Tolvanen
 <samitolvanen@...gle.com>, Daniel Gomez <da.gomez@...sung.com>,
 Nathan Chancellor <nathan@...nel.org>,
 Nicolas Schier <nicolas.schier@...ux.dev>
Cc: linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
 linux-kbuild@...r.kernel.org, Xianwei Zhao <xianwei.zhao@...ogic.com>,
 Linus Walleij <linus.walleij@...aro.org>, Kevin Hilman
 <khilman@...libre.com>, linux-amlogic@...ts.infradead.org,
 linux-gpio@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v5 06/10] pinctrl: meson: Fix typo in device table macro

On 24/07/2025 15:49, Alexey Gladkov wrote:
> The typo when using the MODULE_DEVICE_TABLE macro was not noticeable
> because the macro was defined only if the module was built as a separate
> module.
> 
> Cc: Xianwei Zhao <xianwei.zhao@...ogic.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Neil Armstrong <neil.armstrong@...aro.org>
> Cc: Kevin Hilman <khilman@...libre.com>
> Cc: linux-amlogic@...ts.infradead.org
> Cc: linux-gpio@...r.kernel.org
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507220009.8HKbNP16-lkp@intel.com/
> Signed-off-by: Alexey Gladkov <legion@...nel.org>
> ---
>   drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> index 385cc619df13..95525e66e5c0 100644
> --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c
> @@ -1023,7 +1023,7 @@ static const struct of_device_id aml_pctl_of_match[] = {
>   	{ .compatible = "amlogic,pinctrl-a4", },
>   	{ /* sentinel */ }
>   };
> -MODULE_DEVICE_TABLE(of, aml_pctl_dt_match);
> +MODULE_DEVICE_TABLE(of, aml_pctl_of_match);
>   
>   static struct platform_driver aml_pctl_driver = {
>   	.driver = {

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>