linux-kernel - Re: [PATCH RFC v3] mm: memory-tiering: Fix PGPROMOTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecc1622e-1076-4c03-9e1b-44aa701e6a5c@fujitsu.com>
Date: Thu, 24 Jul 2025 03:35:39 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: "Shiyang Ruan (Fujitsu)" <ruansy.fnst@...itsu.com>, "linux-mm@...ck.org"
	<linux-mm@...ck.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lkp@...el.com" <lkp@...el.com>, "ying.huang@...ux.alibaba.com"
	<ying.huang@...ux.alibaba.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "Yasunori Gotou (Fujitsu)" <y-goto@...itsu.com>,
	"mingo@...hat.com" <mingo@...hat.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
	"vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
	"dietmar.eggemann@....com" <dietmar.eggemann@....com>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "mgorman@...e.de" <mgorman@...e.de>,
	"vschneid@...hat.com" <vschneid@...hat.com>, Ben Segall <bsegall@...gle.com>
Subject: Re: [PATCH RFC v3] mm: memory-tiering: Fix PGPROMOTE_CANDIDATE
 counting



On 22/07/2025 22:16, Ruan Shiyang wrote:
> From: Li Zhijian<lizhijian@...itsu.com>
> 

I believe you are the actual author of this patch, so please change to yourself :)


> Cc: Juri Lelli<juri.lelli@...hat.com>
> Cc: Vincent Guittot<vincent.guittot@...aro.org>
> Cc: Dietmar Eggemann<dietmar.eggemann@....com>
> Cc: Steven Rostedt<rostedt@...dmis.org>
> Cc: Ben Segall<bsegall@...gle.com>
> Cc: Mel Gorman<mgorman@...e.de>
> Cc: Valentin Schneider<vschneid@...hat.com>
> Reported-by: Yasunori Gotou (Fujitsu)<y-goto@...itsu.com>
> Signed-off-by: Li Zhijian<lizhijian@...itsu.com>
> Signed-off-by: Ruan Shiyang<ruansy.fnst@...itsu.com>
> ---
>   include/linux/mmzone.h | 2 ++
>   kernel/sched/fair.c    | 6 ++++--
>   mm/vmstat.c            | 1 +
>   3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 283913d42d7b..6216e2eecf3b 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -231,6 +231,8 @@ enum node_stat_item {
>   #ifdef CONFIG_NUMA_BALANCING
>   	PGPROMOTE_SUCCESS,	/* promote successfully */
>   	PGPROMOTE_CANDIDATE,	/* candidate pages to promote */

Additionally, I think the current comment for PGPROMOTE_CANDIDATE is inaccurate. If possible, I'd like to refine it along with this patch.
For example:
	/*
	 * Candidate pages for promotion based on hint fault latency. This counter
	 * is used to control the promotion rate and adjust the hotness threshold.
	 */
What are your thoughts, @Ying?



> +	PGPROMOTE_CANDIDATE_NOLIMIT,	/* candidate pages without considering
> +					 * hot threshold */

Similarly, the comment for PGPROMOTE_CANDIDATE_NOLIMIT can also be made more precise.


Thanks
Zhijian

>   #endif