linux-kernel - Re: [PATCH] gpiolib: make legacy interfaces optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfxD+qGjamV+rCg766GyuMwVDUe_uOrUGGe=kr83v6Fsg@mail.gmail.com>
Date: Thu, 24 Jul 2025 16:24:17 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Arnd Bergmann <arnd@...db.de>
Cc: Arnd Bergmann <arnd@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Peng Fan <peng.fan@....com>, Lee Jones <lee@...nel.org>, 
	Koichiro Den <koichiro.den@...onical.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Alexander Sverdlin <alexander.sverdlin@...il.com>, Uwe Kleine-König <ukleinek@...nel.org>, 
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: make legacy interfaces optional

On Thu, Jul 24, 2025 at 4:22 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Wed, Jul 23, 2025, at 10:39, Bartosz Golaszewski wrote:
> > On Tue, Jul 22, 2025 at 5:36 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> >>  #include <linux/types.h>
> >> +#ifdef CONFIG_GPIOLIB
> >> +#include <linux/gpio/consumer.h>
> >
> > I want to queue this ASAP but do we really need this guard here?
> > consumer.h already guards against !CONFIG_GPIOLIB internally, right?
>
> I was trying to not change the behavior here. linux/gpio/consumer.h has
> an #ifdef check but has the #else portion with empty stubs that can
> be used by any driver that includes it, while drivers that include
> linux/gpio.h never saw the stub version.
>
>      Arnd

Ok, fair enough, let me queue this and we can change it later if needed.

Bart