linux-kernel - Re: [PATCH] scsi:st.c replace snprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45edee98-b720-4641-a1e8-77b1a96bb340@acm.org>
Date: Thu, 24 Jul 2025 08:24:47 -0700
From: Bart Van Assche <bvanassche@....org>
To: Rujra Bhatt <braker.noob.kernel@...il.com>, Kai.Makisara@...umbus.fi,
 James.Bottomley@...senpartnership.com, martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] scsi:st.c replace snprintf() with sysfs_emit()

On 7/23/25 5:58 PM, Rujra Bhatt wrote:
> replace snprintf() with sysfs_emit() or sysfs_emit_at() in st.c file to
> follow kernel's guidelines from Documentation/filesystems/sysfs.rst
> This improves safety, consistency and easier to maintain and update it
> in the future.

sysfs_emit() is for new code only. There is no requirement to convert
existing code to sysfs_emit() / sysfs_emit_at().

Bart.