linux-kernel - Re: [PATCH v2 1/3] dt-bindings: sound: add bindings for pm4125 audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b012ae4-32b8-4de8-97a5-9b73cced2e4c@kernel.org>
Date: Thu, 24 Jul 2025 17:48:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>, Lee Jones <lee@...nel.org>
Cc: Srinivas Kandagatla <srini@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: sound: add bindings for pm4125 audio
 codec

On 24/07/2025 17:17, Alexey Klimov wrote:
> On Fri Jul 18, 2025 at 2:43 PM BST, Lee Jones wrote:
>> On Fri, 11 Jul 2025, Alexey Klimov wrote:
>>
>>> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
>>> It has TX and RX soundwire slave devices hence two files are added.
>>>
>>> While at this, also add pattern for respecive node in mfd
>>> qcom,spmi-pmic schema so the devicetree for this audio block of
>>> PMIC can be validated properly.
>>>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
>>> ---
>>>  .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml    |   4 +-
>>>  .../bindings/sound/qcom,pm4125-codec.yaml          | 134 +++++++++++++++++++++
>>>  .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml |  79 ++++++++++++
>>
>> Do you have to submit these all in a single patch?
> 
> qcom,pm4125-codec.yaml and qcom,pm4125-sdw.yaml describe one device (sub-device)
> and change for qcom,spmi-pmic.yaml is needed to avoid failing dtbs check.

Preferred way to solve this is to just list compatibles, instead of
other schema, just like all qcom display bindings are doing.

Best regards,
Krzysztof