linux-kernel - Re: [PATCH v2] spi: intel: Allow writeable MTD partition with module param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <433a3da1-f0ff-4b04-86b7-3e2359498b6f@sirena.org.uk>
Date: Thu, 24 Jul 2025 16:59:43 +0100
From: Mark Brown <broonie@...nel.org>
To: Jakub Czapiga <czapiga@...gle.com>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Konrad Adamczyk <konrada@...gle.com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi: intel: Allow writeable MTD partition with module
 param

On Thu, Jul 17, 2025 at 03:28:51PM +0000, Jakub Czapiga wrote:
> The MTD device is blocked from writing to the SPI-NOR chip if any region
> of it is write-protected, even if "writeable=1" module parameter is set.
> 
> Add ability to bypass this behaviour by introducing new module parameter
> "ignore_protestion_status" which allows to rely on the write protection
> mechanism of SPI-NOR chip itself, which most modern chips (since
> the 1990'+) have already implemented.

This doesn't compile:

/build/stage/linux/drivers/spi/spi-intel.c:196:2: error: expected identifier
  196 |         "Do not block SPI flash chip write access even if it is write-protected (default=0)");
      |         ^
/build/stage/linux/drivers/spi/spi-intel.c:194:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
  194 | MODULE_PRAM_DESC(
      | ^
      | int
/build/stage/linux/drivers/spi/spi-intel.c:194:17: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
  194 | MODULE_PRAM_DESC(
      |                 ^
  195 |         ignore_protection_status,
  196 |         "Do not block SPI flash chip write access even if it is write-protected (default=0)");
      |                                                                                             
      |                                                                                             void

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)