linux-kernel - Re: [PATCH] powerpc/thp: tracing: Hide hugepage events under CONFIG_PPC_BOOK3S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20325814-43fd-4509-b4e8-56f169e50e2a@redhat.com>
Date: Thu, 24 Jul 2025 18:13:33 +0200
From: David Hildenbrand <david@...hat.com>
To: Steven Rostedt <rostedt@...dmis.org>, LKML
 <linux-kernel@...r.kernel.org>,
 Linux trace kernel <linux-trace-kernel@...r.kernel.org>, linux-mm@...ck.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH] powerpc/thp: tracing: Hide hugepage events under
 CONFIG_PPC_BOOK3S_64

On 24.07.25 15:28, Steven Rostedt wrote:
> 
> Anyone have any issues with this patch? Should I take it in my tree?
> 

Huh, I was CCed on the patch but cannot find it in my inbox.

If it compiles, all good:

Acked-by: David Hildenbrand <david@...hat.com>

> -- Steve
> 
> 
> On Thu, 12 Jun 2025 10:12:59 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
>> From: Steven Rostedt <rostedt@...dmis.org>
>>
>> The events hugepage_set_pmd, hugepage_set_pud, hugepage_update_pmd and
>> hugepage_update_pud are only called when CONFIG_PPC_BOOK3S_64 is defined.
>> As each event can take up to 5K regardless if they are used or not, it's
>> best not to define them when they are not used. Add #ifdef around these
>> events when they are not used.
>>
>> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
>> ---
>> Note, I will be adding code soon that will make unused events cause a warning.
>>
>>   include/trace/events/thp.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/trace/events/thp.h b/include/trace/events/thp.h
>> index f50048af5fcc..c8fe879d5828 100644
>> --- a/include/trace/events/thp.h
>> +++ b/include/trace/events/thp.h
>> @@ -8,6 +8,7 @@
>>   #include <linux/types.h>
>>   #include <linux/tracepoint.h>
>>   
>> +#ifdef CONFIG_PPC_BOOK3S_64
>>   DECLARE_EVENT_CLASS(hugepage_set,
>>   
>>   	    TP_PROTO(unsigned long addr, unsigned long pte),
>> @@ -66,6 +67,7 @@ DEFINE_EVENT(hugepage_update, hugepage_update_pud,
>>   	    TP_PROTO(unsigned long addr, unsigned long pud, unsigned long clr, unsigned long set),
>>   	    TP_ARGS(addr, pud, clr, set)
> 
>>   );
>> +#endif /* CONFIG_PPC_BOOK3S_64 */
>>   
>>   DECLARE_EVENT_CLASS(migration_pmd,
>>   
> 


-- 
Cheers,

David / dhildenb