linux-kernel - Re: [PATCH] riscv: dts: starfive: jh7110-common: drop no-sdio property from mmc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250724-equal-limb-2922f240961e@spud>
Date: Thu, 24 Jul 2025 17:51:45 +0100
From: Conor Dooley <conor@...nel.org>
To: E Shattow <e@...eshell.de>
Cc: Emil Renner Berthing <kernel@...il.dk>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: drop no-sdio
 property from mmc1

On Thu, Jul 24, 2025 at 12:55:53AM -0700, E Shattow wrote:
> Drop no-sdio property avoids a delete-property on variant board dts
> having an SDIO wireless module connected to mmc1.

I'm struggling to understand why this change is correct.

If there are specific boards that have wireless modules connected
instead of using sdcards, how come the no-sdio property isn't moved to the
the boards that do have sdcard slots?
The property was added for the visionfive 2, and only on mmc1, so should
it be retained for boards that match the visionfive 2 in terms of how
they use mmc?

Could you add an explanation for why removing this entirely is the right
thing to do, rather than only removing it for these variant boards?

Cheers,
Conor.

> 
> Signed-off-by: E Shattow <e@...eshell.de>
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 2eaf01775ef5..a315113840e5 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -299,7 +299,6 @@ &mmc1 {
>  	assigned-clock-rates = <50000000>;
>  	bus-width = <4>;
>  	bootph-pre-ram;
> -	no-sdio;
>  	no-mmc;
>  	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
>  	disable-wp;
> 
> base-commit: 28fa0dcb571ab8f3be4d919f0e20e01d4e44bcb1
> -- 
> 2.50.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)