linux-kernel - Re: [PATCH v2 0/3] rust: xarray: add `insert` and `reserve`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <39015200-6AB5-4331-A679-C0CF6DB4B930@collabora.com>
Date: Thu, 24 Jul 2025 15:50:09 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Andreas Hindborg <a.hindborg@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 Matthew Wilcox <willy@...radead.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org,
 Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v2 0/3] rust: xarray: add `insert` and `reserve`

Hi Tamir,

> On 13 Jul 2025, at 09:05, Tamir Duberstein <tamird@...il.com> wrote:
> 
> The reservation API is used by asahi; currently they use their own
> abstractions but intend to use these when available.
> 
> Rust Binder intends to use the reservation API as well.
> 
> Daniel Almeida mentions a use case for `insert_limit`, but didn't name
> it specifically.

Here is a patch that tests your code on Tyr [0]. I sadly didn't realize in time
that you were using impl RangeBounds as an argument to insert_limit(), which is
even nicer :)

Our internal tests still pass.

I also double-checked that the kunit/doctests pass, just in case.

> 
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> Changes in v2:
> - Explain the need to disambiguate `Iterator::chain`. (Boqun Feng)
> - Mention what `Guard::alloc` does in the doc comment. (Miguel Ojeda)
> - Include new APIs in the module-level example. (Miguel Ojeda)
> - Mention users of these APIs in the cover letter.
> - Link to v1: https://lore.kernel.org/r/20250701-xarray-insert-reserve-v1-0-25df2b0d706a@gmail.com
> 
> ---
> Tamir Duberstein (3):
>      rust: xarray: use the prelude
>      rust: xarray: implement Default for AllocKind
>      rust: xarray: add `insert` and `reserve`
> 
> include/linux/xarray.h |   2 +
> lib/xarray.c           |  28 ++-
> rust/helpers/xarray.c  |   5 +
> rust/kernel/xarray.rs  | 533 ++++++++++++++++++++++++++++++++++++++++++++++---
> 4 files changed, 536 insertions(+), 32 deletions(-)
> ---
> base-commit: 2009a2d5696944d85c34d75e691a6f3884e787c0
> change-id: 20250701-xarray-insert-reserve-bd811ad46a1d
> 
> Best regards,
> --  
> Tamir Duberstein <tamird@...il.com>
> 
> 

Thanks a lot for working on this. It will definitely be used by us.


Tested-By: Daniel Almeida <daniel.almeida@...labora.com>
Reviewed-By: Daniel Almeida <daniel.almeida@...labora.com>

[0] https://gitlab.freedesktop.org/panfrost/linux/-/commit/791de453eb103af37e3cc6825e042f26d4c76426