[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1a8bdd00-aaa3-49bb-954e-52c84dad63a3@kernel.org>
Date: Thu, 24 Jul 2025 20:58:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joy Zou <joy.zou@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, imx@...ts.linux.dev, Frank Li
<Frank.Li@....com>, Ye Li <ye.li@....com>, Jacky Bai <ping.bai@....com>,
Dong Aisheng <aisheng.dong@....com>
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add PF0900 regulator yaml
On 24/07/2025 12:51, Joy Zou wrote:
>>> + type: object
>>> + $ref: regulator.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + patternProperties:
>>> + "^LDO[1-3]$":
>>> + type: object
>>> + $ref: regulator.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + "^SW[1-5]$":
>>> + type: object
>>> + $ref: regulator.yaml#
>>> + unevaluatedProperties: false
>>> +
>>> + properties:
>>> + nxp,dvs-run-microvolt:
>>> + minimum: 300000
>>> + maximum: 1350000
>>> + description:
>>> + PMIC default "RUN" state voltage in uV.
>>
>> Why existing properties are not suitable?
> Have not found the property that can set run state voltage in regulator.yaml.
> Can we add a property for run state such as regulator-suspend-microvolt?
>>
>>> +
>>> + nxp,dvs-standby-microvolt:
>>
>> Why existing standby state bindings are not suitable?
> Have found regulator-suspend-microvolt property that can set standby state voltage.
> But the regulator-suspend-microvolt property is now deprecated. Can we use it?
You have regulator-min/max properties for that. Please check with
bindings and other existing code how this looks like. I feel like you
did not try enough to solve it with existing code.
Best regards,
Krzysztof
Powered by blists - more mailing lists