linux-kernel - Re: [PATCH net-next v2 3/5] netconsole: add support for strings with new line in netpoll_parse_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250724201139.GE1266901@horms.kernel.org>
Date: Thu, 24 Jul 2025 21:11:39 +0100
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v2 3/5] netconsole: add support for strings with
 new line in netpoll_parse_ip_addr

On Wed, Jul 23, 2025 at 10:37:59AM -0700, Breno Leitao wrote:
> On Wed, Jul 23, 2025 at 03:54:11PM +0100, Simon Horman wrote:
> > On Mon, Jul 21, 2025 at 06:02:03AM -0700, Breno Leitao wrote:
> 
> > > --- a/drivers/net/netconsole.c
> > > +++ b/drivers/net/netconsole.c
> > > @@ -303,20 +303,21 @@ static void netconsole_print_banner(struct netpoll *np)
> > >  static int netpoll_parse_ip_addr(const char *str, union inet_addr *addr)
> > >  {
> > >  	const char *end;
> > > +	int len;
> > >  
> > > -	if (!strchr(str, ':') &&
> > > -	    in4_pton(str, -1, (void *)addr, -1, &end) > 0) {
> > > -		if (!*end)
> > > -			return 0;
> > > -	}
> > > -	if (in6_pton(str, -1, addr->in6.s6_addr, -1, &end) > 0) {
> > > -#if IS_ENABLED(CONFIG_IPV6)
> > > -		if (!*end)
> > > -			return 1;
> > > -#else
> > > +	len = strlen(str);
> > > +	if (!len)
> > >  		return -1;
> > > +
> > > +	if (str[len - 1] == '\n')
> > > +		len -= 1;
> > > +
> > > +	if (in4_pton(str, len, (void *)addr, -1, &end) > 0)
> > > +		return 0;
> > > +#if IS_ENABLED(CONFIG_IPV6)
> > > +	if (in6_pton(str, len, addr->in6.s6_addr, -1, &end) > 0)
> > > +		return 1;
> > >  #endif
> > 
> > I don't think it needs to block progress.
> > But FWIIW, I think it would be nice to increase
> > build coverage and express this as:
> 
> Agree. While testing with IPv6 disabled, the netcons selftest exploded,
> so, this explose a bug in the selftest. This is now fixed in:
> 
> 	https://lore.kernel.org/all/20250723-netcons_test_ipv6-v1-1-41c9092f93f9@debian.org/

Nice, good to find bugs.