linux-kernel - Re: [PATCH v2] selftests/pidfd: Fix duplicate-symbol warnings for SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51840986-f959-4f71-9be6-75519d0a08f3@paulmck-laptop>
Date: Thu, 24 Jul 2025 16:29:01 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Christian Brauner <brauner@...nel.org>, Shuah Khan <shuah@...nel.org>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2] selftests/pidfd: Fix duplicate-symbol warnings for
 SCHED_ CPP symbols

On Thu, Jul 24, 2025 at 04:17:07PM -0600, Shuah Khan wrote:
> On 7/24/25 12:26, Shuah Khan wrote:
> > On 7/23/25 17:13, Paul E. McKenney wrote:
> > > The pidfd selftests run in userspace and include both userspace and kernel
> > > header files.  On some distros (for example, CentOS), this results in
> > > duplicate-symbol warnings in allmodconfig builds, while on other distros
> > > (for example, Ubuntu) it does not.
> > > 
> > > Therefore, use #undef to get rid of the userspace definitions in favor
> > > of the kernel definitions.
> > > 
> > > Other ways of handling this include splitting up the selftest code so
> > > that the userspace definitions go into one translation unit and the
> > > kernel definitions into another (which might or might not be feasible)
> > > or to adjust compiler command-line options to suppress the warnings
> > > (which might or might not be desirable).
> > > 
> > > [ paulmck: Apply Shuah Khan feedback. ]
> > 
> > Looks good to me.
> 
> I picked this up for Linux 6.17-rc1.

Thank you, Shuah!

							Thanx, Paul