linux-kernel - RE: [PATCH v3 RESEND 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b5c01dbfc5f$40a8f970$c1faec50$@samsung.com>
Date: Thu, 24 Jul 2025 11:23:15 +0530
From: "Alim Akhtar" <alim.akhtar@...sung.com>
To: "'Sangwook Shin'" <sw617.shin@...sung.com>, <krzk@...nel.org>,
	<wim@...ux-watchdog.org>, <linux@...ck-us.net>
Cc: <linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-watchdog@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 RESEND 1/5] watchdog: s3c2410_wdt: Replace hardcoded
 values with macro definitions

Hi Sangwook

> -----Original Message-----
> From: Sangwook Shin <sw617.shin@...sung.com>
> Sent: Monday, July 14, 2025 11:25 AM
> To: krzk@...nel.org; alim.akhtar@...sung.com; wim@...ux-watchdog.org;
> linux@...ck-us.net
> Cc: linux-arm-kernel@...ts.infradead.org; linux-samsung-
> soc@...r.kernel.org; linux-watchdog@...r.kernel.org; linux-
> kernel@...r.kernel.org; Sangwook Shin <sw617.shin@...sung.com>
> Subject: [PATCH v3 RESEND 1/5] watchdog: s3c2410_wdt: Replace hardcoded
> values with macro definitions
> 
> Modify the code to utilize macro-defined values instead of hardcoded values.
> The value 0x100 in the s3c2410wdt_set_heartbeat function represents
> S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its
> meaning difficult to understand and reducing code readability.
> 
> Signed-off-by: Sangwook Shin <sw617.shin@...sung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>