linux-kernel - Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <633ea291-2e02-44be-bd03-220634b3c62d@kernel.org>
Date: Thu, 24 Jul 2025 09:08:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Friday Yang (杨阳) <Friday.Yang@...iatek.com>,
 "robh@...nel.org" <robh@...nel.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 Yong Wu (吴勇) <Yong.Wu@...iatek.com>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp
 for MT8188

On 24/07/2025 03:49, Friday Yang (杨阳) wrote:
> On Thu, 2025-06-12 at 17:16 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 21/05/2025 08:33, Friday Yang wrote:
>>> From: "Friday Yang" <friday.yang@...iatek.com>
>>>
>>> To prevent handling glitch signals during MTCMOS on/off
>>> transitions,
>>> SMI requires clamp and reset operations. Parse the reset settings
>>> for
>>> SMI LARBs and the clamp settings for the SMI Sub-Common. Register
>>> genpd callback for the SMI LARBs located in image, camera and IPE
>>> subsystems, and apply reset and clamp operations within the
>>> callback.
>>>
>>> Signed-off-by: Friday Yang <friday.yang@...iatek.com>
>>> Reviewed-by: AngeloGioacchino Del Regno <
>>> angelogioacchino.delregno@...labora.com>
>>> Acked-by: Rob Herring <robh@...nel.org>
>>
>> You did not respond to previous review. Sending the same while
>> ignoring
>> previous review is obvious NAK.
>>
> 
> Apologies for missing the message. In the v6 patch, I replaced
> 'pm_runtime_enable' with 'devm_pm_runtime_enable'. You pointed out that
> this change might alter the cleanup order and potentially introduce
> errors.
> 
> v6:
> https://lore.kernel.org/lkml/20250408033206.12176-3-friday.yang@mediatek.com/
> 
> Therefore, in the v7 patch, I reverted this change and continued using
> 'pm_runtime_enable' in the SMI driver. However, I did not include a
> clear description of the changes between v6 and v7 in the cover letter.
> 
> v7:
> https://lore.kernel.org/lkml/9f01a9a4-89b2-4bfc-97cd-827be989ef16@kernel.org/
> 
> In the v8 patch, I have added a description in the cover letter.
> This series just add functions for SMI clamp and not change anything
> else. Is this acceptable to you?

That was month ago. Nothing form this thread is in my memory, nothing is
in the mailbox. There is no cover letter to find anymore.

Anyway, you did not respond to the actual comment and you send the same.
Now you respond... to something else still ignoring the comment about
fake tags.

I will not be wasting more time on this patchset.

Best regards,
Krzysztof