linux-kernel - Re: [PATCH 15/38] dt-bindings: phy: mediatek,hdmi-phy: Fix clock output names for MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee525312-bde1-4724-b32f-83be32c87696@kernel.org>
Date: Thu, 24 Jul 2025 11:16:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org, robh@...nel.org
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, krzk+dt@...nel.org,
 conor+dt@...nel.org, chunkuang.hu@...nel.org, p.zabel@...gutronix.de,
 airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, jassisinghbrar@...il.com,
 mchehab@...nel.org, matthias.bgg@...il.com, chunfeng.yun@...iatek.com,
 vkoul@...nel.org, kishon@...nel.org, sean.wang@...nel.org,
 linus.walleij@...aro.org, lgirdwood@...il.com, broonie@...nel.org,
 andersson@...nel.org, mathieu.poirier@...aro.org, daniel.lezcano@...aro.org,
 tglx@...utronix.de, atenart@...nel.org, jitao.shi@...iatek.com,
 ck.hu@...iatek.com, houlong.wei@...iatek.com,
 kyrie.wu@...iatek.corp-partner.google.com, andy.teng@...iatek.com,
 tinghan.shen@...iatek.com, jiaxin.yu@...iatek.com, shane.chien@...iatek.com,
 olivia.wen@...iatek.com, granquet@...libre.com, eugen.hristev@...aro.org,
 arnd@...db.de, sam.shih@...iatek.com, jieyy.yang@...iatek.com,
 frank-w@...lic-files.de, mwalle@...nel.org, fparent@...libre.com,
 linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-phy@...ts.infradead.org, linux-gpio@...r.kernel.org,
 linux-remoteproc@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 15/38] dt-bindings: phy: mediatek,hdmi-phy: Fix clock
 output names for MT8195

On 24/07/2025 10:38, AngeloGioacchino Del Regno wrote:
> For all of the HDMI PHYs compatible with the one found on MT8195
> the output clock has a different datasheet name and specifically
> it is called "hdmi_txpll", differently from the older HDMI PHYs
> which output block is called "hdmitx_dig_cts".
> 
> Add a conditional to allow the new clock output name on all of the
> HDMI PHY IPs that are perfectly compatible with MT8195.
> 
> Fixes: c78fe548b062 ("dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>


Please organize fixes separately from this patchset. You touch here
really too many subsystems and putting fixes in the middle of patchset
is another issue.

> ---
>  .../bindings/phy/mediatek,hdmi-phy.yaml       | 25 ++++++++++++++++---
>  1 file changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> index f3a8b0b745d1..f1207aea8605 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> @@ -26,6 +26,10 @@ properties:
>            - enum:
>                - mediatek,mt7623-hdmi-phy
>            - const: mediatek,mt2701-hdmi-phy
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-hdmi-phy
> +          - const: mediatek,mt8195-hdmi-phy
>        - const: mediatek,mt2701-hdmi-phy
>        - const: mediatek,mt8173-hdmi-phy
>        - const: mediatek,mt8195-hdmi-phy
> @@ -41,9 +45,7 @@ properties:
>      items:
>        - const: pll_ref
>  
> -  clock-output-names:
> -    items:
> -      - const: hdmitx_dig_cts
> +  clock-output-names: true


Instead:
maxItems: 1

>  
>    "#phy-cells":
>      const: 0
> @@ -76,6 +78,23 @@ required:
>    - "#phy-cells"
>    - "#clock-cells"
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - mediatek,mt8195-hdmi-phy
> +then:
> +  properties:
> +    clock-output-names:
> +      items:
> +        - const: hdmi_txpll
> +else:
> +  properties:
> +    clock-output-names:
> +      items:
> +        - const: hdmitx_dig_cts


And drop this if:then:else. Binding should not enforce output clock
naming, because if this is fixed, then you do not need that property at
all. Things which are const are implied by compatible.


Best regards,
Krzysztof