linux-kernel - Re: [PATCH] staging: rtl8723bs: fix if-statement alignment and line continuation in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025072409-promoter-shame-8105@gregkh>
Date: Thu, 24 Jul 2025 11:29:44 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Bruce Qin <bqn9090@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix if-statement alignment and line
 continuation in rtw_ap.c

On Sun, Jul 20, 2025 at 07:34:44PM +0200, Bruce Qin wrote:
> This patch addresses three checkpatch-reported style issues in a multiline
> if-statement:
> 
> - Moved '&&' to the end of the previous line to follow logical continuation style
> - Fixed indentation to align with the opening parenthesis of the expression
> - Avoided ending a line with an open parenthesis '('
> 
> These changes improve readability and conform to Linux kernel coding conventions.
> No functional changes.
> 
> Signed-off-by: Bruce Qin <bqn9090@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 383a6f7c06f4..838d2feed883 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -258,10 +258,9 @@ void expire_timeout_chk(struct adapter *padapter)
>  		} else {
>  			/* TODO: Aging mechanism to digest frames in sleep_q to */
>  			/* avoid running out of xmitframe */
> -			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt)
> -				&& padapter->xmitpriv.free_xmitframe_cnt < ((
> -					NR_XMITFRAME / pstapriv->asoc_list_cnt
> -				) / 2)
> +			if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) &&
> +			    padapter->xmitpriv.free_xmitframe_cnt <
> +					((NR_XMITFRAME / pstapriv->asoc_list_cnt) / 2)
>  			)

Why is this ")" on this line down here?  Shouldn't it be on the previous
one?

thanks,

greg k-h