linux-kernel - Re: [PATCH] net/core: fix wrong return value in __splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250724100610.6702-1-hept.hept.hept@gmail.com>
Date: Thu, 24 Jul 2025 18:06:10 +0800
From: Pengtao He <hept.hept.hept@...il.com>
To: willemdebruijn.kernel@...il.com
Cc: aleksander.lobakin@...el.com,
	almasrymina@...gle.com,
	davem@...emloft.net,
	ebiggers@...gle.com,
	edumazet@...gle.com,
	hept.hept.hept@...il.com,
	horms@...nel.org,
	kerneljasonxing@...il.com,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	mhal@...x.co,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	willemb@...gle.com
Subject: Re: [PATCH] net/core: fix wrong return value in __splice_segment

> Pengtao He wrote:
> > Return true immediately when the last segment is processed,
> > without waiting for the next segment.
> 
> This can use a bit more explanation. Which unnecessary wait is
> avoided.
> 
> The boolean return from __skb_splice_bits has a bit odd semantics. But
> is ignored by its only caller anyway.
> 
> The relevant __splice_segment that can cause an early return is in the
> frags loop. But I see no waiting operation in here.

Sorry, I didn't express it clearly.
There is no wait operation, just avoid to walking once more
in the frags loop before return true.

> 
> Aside from that, the commit also should target [PATCH net-next],
> assuuming that this is an optimization, not a fix.

Ok, the prefix [PATCH net-next] will be used.