linux-kernel - Re: [PATCH v2 2/6] ALSA: Add definitions for the bits in IEC958 subframe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA+D8AN2B_RZ9iZ3qE5zMBfs7BMAkruSRQupoXyrsr7Tt+Gfkg@mail.gmail.com>
Date: Thu, 24 Jul 2025 18:14:10 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Takashi Iwai <tiwai@...e.de>, Shengjiu Wang <shengjiu.wang@....com>, imx@...ts.linux.dev, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Laurent.pinchart@...asonboard.com, andrzej.hajda@...el.com, 
	festevam@...il.com, simona@...ll.ch, robh@...nel.org, rfoss@...nel.org, 
	airlied@...il.com, tiwai@...e.com, jernej.skrabec@...il.com, 
	p.zabel@...gutronix.de, luca.ceresoli@...tlin.com, devicetree@...r.kernel.org, 
	conor+dt@...nel.org, tzimmermann@...e.de, jonas@...boo.se, victor.liu@....com, 
	s.hauer@...gutronix.de, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
	linux-sound@...r.kernel.org, perex@...ex.cz, 
	linux-arm-kernel@...ts.infradead.org, neil.armstrong@...aro.org, 
	lumag@...nel.org, dianders@...omium.org, kernel@...gutronix.de, 
	cristian.ciocaltea@...labora.com, krzk+dt@...nel.org, shawnguo@...nel.org, 
	l.stach@...gutronix.de
Subject: Re: [PATCH v2 2/6] ALSA: Add definitions for the bits in IEC958 subframe

On Thu, Jul 24, 2025 at 3:40 PM Marc Kleine-Budde <mkl@...gutronix.de> wrote:
>
> On 24.07.2025 09:37:09, Takashi Iwai wrote:
> > On Thu, 24 Jul 2025 09:22:44 +0200,
> > Shengjiu Wang wrote:
> > >
> > > The IEC958 subframe format SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE are used
> > > in HDMI and DisplayPort to describe the audio stream, but hardware device
> > > may need to reorder the IEC958 bits for internal transmission, so need
> > > these standard bits definitions for IEC958 subframe format.
> > >
> > > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > > ---
> > >  include/sound/asoundef.h | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > >
> > > diff --git a/include/sound/asoundef.h b/include/sound/asoundef.h
> > > index 09b2c3dffb30..7efd61568636 100644
> > > --- a/include/sound/asoundef.h
> > > +++ b/include/sound/asoundef.h
> > > @@ -12,6 +12,15 @@
> > >   *        Digital audio interface                                      *
> > >   *                                                                          *
> > >   ****************************************************************************/
> > > +/* IEC958 subframe format */
> > > +#define IEC958_SUBFRAME_PREAMBLE_MASK      (0xf)
> > > +#define IEC958_SUBFRAME_AUXILIARY_MASK     (0xf<<4)
> > > +#define IEC958_SUBFRAME_SAMPLE_24_MASK     (0xffffff<<4)
> > > +#define IEC958_SUBFRAME_SAMPLE_20_MASK     (0xfffff<<8)
> > > +#define IEC958_SUBFRAME_VALIDITY   (0x1<<28)
> > > +#define IEC958_SUBFRAME_USER_DATA  (0x1<<29)
> > > +#define IEC958_SUBFRAME_CHANNEL_STATUS     (0x1<<30)
> > > +#define IEC958_SUBFRAME_PARITY             (0x1<<31)
> >
> > I'd use "U" suffix as it can reach to the MSB.
> > Also, you can put spaces around the operators to align with the
> > standard format, too.  I guess you followed to the other code there,
> > but following to the standard coding style would be better.
> >
> > With those addressed, feel free to take my ack for this patch:
>
> Or make use of the BIT() and GEN_MASK() helpers.

Is it acceptable to include the headers in this file?

Best regards
Shengjiu Wang


>
> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |