linux-kernel - Re: [PATCH v2] iio: proximity: srf08: use stack allocated scan buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250724121158.05fb8458@jic23-huawei>
Date: Thu, 24 Jul 2025 12:11:58 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Andreas Klinger
 <ak@...klinger.de>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: proximity: srf08: use stack allocated scan
 buffer

On Tue, 22 Jul 2025 10:10:38 +0100
Nuno Sá <noname.nuno@...il.com> wrote:

> On Mon, Jul 21, 2025 at 05:21:08PM -0500, David Lechner wrote:
> > Use a stack allocated scan struct in srf08_trigger_handler(). Since the
> > scan buffer isn't used outside of this function and doesn't need to be
> > DMA-safe, it doesn't need to be in struct srf08_data. We can also
> > eliminate an extra local variable for the return value of
> > srf08_read_ranging() by using scan.chan directly.
> > 
> > Reviewed-by: Andreas Klinger <ak@...klinger.de>
> > Signed-off-by: David Lechner <dlechner@...libre.com>
> > ---
> > Changes in v2:
> > - Zero-init the scan struct to avoid leaking uninitialized stack to userspace.
> > - Link to v1: https://lore.kernel.org/r/20250711-iio-use-more-iio_declare_buffer_with_ts-6-v1-1-25c70b990d6c@baylibre.com
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
Applied to the testing branch of iio.git.

Thanks,

Jonathan