linux-kernel - Re: [PATCH 04/38] ASoC: dt-bindings: mt8192-afe-pcm: Fix clocks and clock-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175335596838.1587473.6783798436849190740.robh@kernel.org>
Date: Thu, 24 Jul 2025 06:19:30 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: frank-w@...lic-files.de, herbert@...dor.apana.org.au, 
 maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de, 
 linux-phy@...ts.infradead.org, krzk+dt@...nel.org, eugen.hristev@...aro.org, 
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, 
 jiaxin.yu@...iatek.com, jitao.shi@...iatek.com, daniel.lezcano@...aro.org, 
 linux-remoteproc@...r.kernel.org, granquet@...libre.com, 
 lgirdwood@...il.com, linux-crypto@...r.kernel.org, 
 tinghan.shen@...iatek.com, mwalle@...nel.org, sam.shih@...iatek.com, 
 sean.wang@...nel.org, p.zabel@...gutronix.de, matthias.bgg@...il.com, 
 vkoul@...nel.org, mripard@...nel.org, 
 kyrie.wu@...iatek.corp-partner.google.com, olivia.wen@...iatek.com, 
 dri-devel@...ts.freedesktop.org, atenart@...nel.org, arnd@...db.de, 
 conor+dt@...nel.org, shane.chien@...iatek.com, houlong.wei@...iatek.com, 
 devicetree@...r.kernel.org, kishon@...nel.org, fparent@...libre.com, 
 airlied@...il.com, tglx@...utronix.de, linux-sound@...r.kernel.org, 
 broonie@...nel.org, andy.teng@...iatek.com, jieyy.yang@...iatek.com, 
 mathieu.poirier@...aro.org, chunfeng.yun@...iatek.com, 
 linux-arm-kernel@...ts.infradead.org, jassisinghbrar@...il.com, 
 linux-media@...r.kernel.org, davem@...emloft.net, simona@...ll.ch, 
 linus.walleij@...aro.org, chunkuang.hu@...nel.org, ck.hu@...iatek.com, 
 andersson@...nel.org, linux-mediatek@...ts.infradead.org, 
 mchehab@...nel.org
Subject: Re: [PATCH 04/38] ASoC: dt-bindings: mt8192-afe-pcm: Fix clocks
 and clock-names


On Thu, 24 Jul 2025 10:38:40 +0200, AngeloGioacchino Del Regno wrote:
> Both clocks and clock-names are missing (a lot of) entries: add
> all the used audio clocks and their description and also fix the
> example node.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../bindings/sound/mt8192-afe-pcm.yaml        | 106 +++++++++++++++++-
>  1 file changed, 104 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.example.dtb: mt8192-afe-pcm (mediatek,mt8192-audio): clock-names:3: 'aud_adc_clk' was expected
	from schema $id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.example.dtb: mt8192-afe-pcm (mediatek,mt8192-audio): clock-names:4: 'aud_adda6_adc_clk' was expected
	from schema $id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.example.dtb: mt8192-afe-pcm (mediatek,mt8192-audio): clock-names: ['aud_afe_clk', 'aud_dac_clk', 'aud_dac_predis_clk', 'aud_infra_clk', 'aud_infra_26m_clk'] is too short
	from schema $id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.example.dtb: mt8192-afe-pcm (mediatek,mt8192-audio): clocks: [[4294967295, 0], [4294967295, 7], [4294967295, 8], [4294967295, 47], [4294967295, 58]] is too short
	from schema $id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250724083914.61351-5-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.