linux-kernel - Re: [PATCH 13/38] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175335597061.1587930.6517956701582557579.robh@kernel.org>
Date: Thu, 24 Jul 2025 06:19:34 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: tinghan.shen@...iatek.com, linux-remoteproc@...r.kernel.org, 
 olivia.wen@...iatek.com, devicetree@...r.kernel.org, 
 linux-sound@...r.kernel.org, andy.teng@...iatek.com, 
 eugen.hristev@...aro.org, matthias.bgg@...il.com, 
 linux-mediatek@...ts.infradead.org, frank-w@...lic-files.de, 
 linux-phy@...ts.infradead.org, mripard@...nel.org, atenart@...nel.org, 
 sean.wang@...nel.org, ck.hu@...iatek.com, fparent@...libre.com, 
 granquet@...libre.com, p.zabel@...gutronix.de, simona@...ll.ch, 
 tglx@...utronix.de, dri-devel@...ts.freedesktop.org, 
 linux-gpio@...r.kernel.org, chunkuang.hu@...nel.org, 
 linux-crypto@...r.kernel.org, vkoul@...nel.org, 
 maarten.lankhorst@...ux.intel.com, andersson@...nel.org, 
 linux-arm-kernel@...ts.infradead.org, shane.chien@...iatek.com, 
 davem@...emloft.net, herbert@...dor.apana.org.au, broonie@...nel.org, 
 houlong.wei@...iatek.com, mathieu.poirier@...aro.org, 
 linus.walleij@...aro.org, conor+dt@...nel.org, 
 kyrie.wu@...iatek.corp-partner.google.com, daniel.lezcano@...aro.org, 
 mchehab@...nel.org, tzimmermann@...e.de, chunfeng.yun@...iatek.com, 
 mwalle@...nel.org, jiaxin.yu@...iatek.com, airlied@...il.com, 
 jassisinghbrar@...il.com, krzk+dt@...nel.org, linux-kernel@...r.kernel.org, 
 kishon@...nel.org, arnd@...db.de, linux-media@...r.kernel.org, 
 jieyy.yang@...iatek.com, lgirdwood@...il.com, sam.shih@...iatek.com, 
 jitao.shi@...iatek.com
Subject: Re: [PATCH 13/38] dt-bindings: remoteproc: mediatek: Remove l1tcm
 MMIO from MT8188 dual


On Thu, 24 Jul 2025 10:38:49 +0200, AngeloGioacchino Del Regno wrote:
> Even though the MT8188 SoC's Dual-Core SCP IP is practically the
> same as the one found on MT8195, it doesn't have a dedicated L1
> TCM and relies only on SRAM.
> 
> Set reg/reg-names minItems to 1 globally and override it in all of
> the conditionals for the SoCs that require more, and then split
> the mt8195/8188 conditionals to allow specifying only the cfg MMIO
> on MT8188.
> 
> Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../bindings/remoteproc/mtk,scp.yaml          | 23 ++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml: allOf:1:then:properties:reg-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'sram'}, {'const': 'cfg'}] is too long
	[{'const': 'sram'}, {'const': 'cfg'}] is too short
	False schema does not allow 2
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml: allOf:3:then:properties:reg-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'cfg'}] is too short
	False schema does not allow 1
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml: allOf:4:then:properties:reg-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'cfg'}, {'const': 'l1tcm'}] is too long
	[{'const': 'cfg'}, {'const': 'l1tcm'}] is too short
	False schema does not allow 2
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250724083914.61351-14-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.